[ 
https://issues.apache.org/jira/browse/LOG4NET-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508623#comment-13508623
 ] 

Dominik Psenner edited comment on LOG4NET-27 at 12/3/12 10:16 AM:
------------------------------------------------------------------

Hi Jochen. I just copied your RollingFileAppender.cs over the latest in SVN and 
see lots of differences. For example the DateTimeStrategy property is missing 
and some other things don't look sensible. Like this I cannot apply your file 
as it would break other things. But if you could integrate your patch into the 
latest trunk I gladly review it.
                
      was (Author: nachbarslumpi):
    Hi Jochen. I just copied your RollingFileAppender.cs over the latest in SVN 
and see lots of differences. For example the DateTiemStrategy property is 
missing and some other things don't look sensible. Like this I cannot apply 
your file as it would break other things. But if you could integrate your patch 
into the latest trunk I gladly review it.
                  
> Rolling files on date/time boundaries doesn't support a maximum number of 
> backup files.
> ---------------------------------------------------------------------------------------
>
>                 Key: LOG4NET-27
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-27
>             Project: Log4net
>          Issue Type: New Feature
>          Components: Appenders
>    Affects Versions: 1.2.11
>            Reporter: Florian Ramillien
>            Priority: Minor
>             Fix For: 1.2 Maintenance Release
>
>         Attachments: LOG4NET-27.patch, RollingFileAppender.cs, 
> RollingFileAppender.cs, RollingFileAppender.cs, RollingFileAppender.cs.patch, 
> RollingFileAppender.patch
>
>
> A maximum of backup files exist when rolling files on file size, but not for 
> rolling on date/time.
> This can be implemented with the same config key : MaxSizeRollBackups

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to