[ https://issues.apache.org/jira/browse/LOG4NET-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721200#comment-14721200 ]
Albin Sunnanbo commented on LOG4NET-472: ---------------------------------------- I got rid of the {{+ 1}}. Regarding the lock I'm not familiar enough with the internals of Log4Net. If you log from different threads in your application, are the log events processed internally in sequence by a single thread? In such case it could be removed. I trust Eric Lippert that uncontended locks are very cheap [(about 10 nano seconds)|http://stackoverflow.com/a/19384758/401728] and thought better safe than sorry. I'll see if I can whip up a conclusive test. > Contribution of BurstFilter > --------------------------- > > Key: LOG4NET-472 > URL: https://issues.apache.org/jira/browse/LOG4NET-472 > Project: Log4net > Issue Type: New Feature > Components: Other > Affects Versions: 1.2.13 > Reporter: Albin Sunnanbo > Priority: Minor > > Hi > I wrote a BurstFilter implementation for Log4net a while ago, trying to mimic > the API of BurstFilter for Log4j > https://logging.apache.org/log4j/2.0/log4j-core/apidocs/org/apache/logging/log4j/core/filter/BurstFilter.html > I have published my source code on our company GitHub account: > https://github.com/KentorIT/Log4NetExtensions > But I would of course be happy to contribute the extension back to the main > project on apache.org. > Would a contribution be accepted and in such case how would you like the > contribution served? As a diff in this Jira issue? -- This message was sent by Atlassian JIRA (v6.3.4#6332)