Github user albinsunnanbo commented on a diff in the pull request:

    https://github.com/apache/log4net/pull/18#discussion_r43581266
  
    --- Diff: src/Appender/SmtpPickupDirAppender.cs ---
    @@ -196,6 +196,7 @@ override protected void SendBuffer(LoggingEvent[] 
events)
                                                writer.WriteLine("To: " + m_to);
                                                writer.WriteLine("From: " + 
m_from);
                                                writer.WriteLine("Subject: " + 
m_subject);
    +                                           writer.WriteLine("Date: " + 
DateTime.UtcNow.ToString("r"));
    --- End diff --
    
    I have used `DateTime.UtcNow` as time reference, are there any better 
internal date properties that should be used. Like `LoggingEvent.TimeStamp`?
    I think `DateTime.UtcNow` as the Date header should denote the time 
authoring the email, not related to the loggingevents contained in the mail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to