[
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374790#comment-15374790
]
ASF GitHub Bot commented on LOG4NET-467:
----------------------------------------
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70600774
--- Diff: tests/src/Utils.cs ---
@@ -105,7 +114,28 @@ private static Type[] GetTypesArray(object[] args)
internal static void RemovePropertyFromAllContexts() {
GlobalContext.Properties.Remove(PROPERTY_KEY);
ThreadContext.Properties.Remove(PROPERTY_KEY);
+#if !(NETCF || NETSTANDARD1_3)
LogicalThreadContext.Properties.Remove(PROPERTY_KEY);
+#endif
}
- }
+
+ // Wrappers because repository/logger retrieval APIs require an
Assembly argument on NETSTANDARD1_3
+ internal static ILog GetLogger(string name)
+ {
+#if NETSTANDARD1_3
+ return
LogManager.GetLogger(typeof(Utils).GetTypeInfo().Assembly, name);
+#else
+ return LogManager.GetLogger(name);
+#endif
--- End diff --
nit: indentation of either one of two return statements is off
> Is .NET Core, will be supported in the near future, or not
> ----------------------------------------------------------
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.2.13
> Reporter: san kan
> Labels: features
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
