GitHub user jasonwilliams200OK opened a pull request:
https://github.com/apache/log4net/pull/30
Misc. fixes for netstandard
This PR:
- fix the failing build by providing `[Read/Write]Async` overloads for
net45 and netstandard TFMs in FileAppender. This was a miss in #16 as
netstandard doesn't have Begin/End Read/Write methods.
- covers some minor code feedback given at
https://github.com/apache/log4net/pull/16 and code cleanup.
---
FYI: to build the project with .NET CLI on various platforms (downloadable
from https://dot.net/core), run the following sequence of commands:
```sh
git clone https://github.com/apache/log4net --recursive
cd log4net/netstandard
dotnet restore
dotnet test log4net.tests # this will build log4net.tests,
# it's dependency log4net and run tests; all
in one command!
```
I have tested on macOS and Windows and the test result is consistent:
> Test Count: 145, Passed: 107, Failed: 30, Inconclusive: 0, Skipped: 8
/cc @bodewig
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jasonwilliams200OK/log4net trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/log4net/pull/30.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #30
----
commit f6e66d0c0ae67e533ed1ed09e2218e1aa26514d0
Author: Peter Jas <[email protected]>
Date: 2016-08-13T14:43:25Z
Misc. fixes for netstandard
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
