Re: $_ENV vs $_SERVER in LoggerOptionConverter

[Knut Urdalen]

Christian Hammers wrote:
         if (defined($key)) {
             return (string)constant($key);
-        } elseif (isset($_ENV[$key])) {
-            return (string)$_ENV[$key];
+        } elseif (isset($_SERVER[$key])) {
+            return (string)$_SERVER[$key];
         } else {
             return $def;
         }
  
Hi,
I think it's safe to add the $_SERVER variable here, and check it before 
$_ENV. But still keep $_ENV like this:

        if (defined($key)) {
            return (string)constant($key);
+        } elseif (isset($_SERVER[$key])) {
+            return (string)$_SERVER[$key];
        } elseif (isset($_ENV[$key])) {
            return (string)$_ENV[$key];
        } else {
            return $def;
        }

Do you agree?

Regards,
Knut Urdalen