> -----Original Message----- > From: Knut Urdalen (JIRA) [mailto:[email protected]] > Sent: Tuesday, 28 April 2009 5:05 PM > To: [email protected] > Subject: [jira] Closed: (LOG4PHP-21) Incorrect params passed in > set_include_path > > > [ https://issues.apache.org/jira/browse/LOG4PHP- > 21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] > > Knut Urdalen closed LOG4PHP-21. > ------------------------------- > > Resolution: Fixed > > Thanks! This is now fixed in trunk. (note that due to the refactoring of > our unit test suite yesterday phpunit.php is removed in favor of > phpunit.xml and bootstrap.php).
Thanks Knut for being a busy bee today. With this patch, Ion pointed out the issue as well as provided a solution to the problem. Because of refactoring you had to apply it differently. With all the talk of authors and who did what etc, one of the things I would like to see moving forward which I mentioned in the other thread, is the attribution of patches etc in the svn log message. So your log message for the above issue correctly ties in to the Jira Issue :- Log: fixed #LOG4PHP-21 but in cases like these I would like to see something like :- Log: fixed #LOG4PHP-21 - Due to Ion CERTEJAN or Log: fixed #LOG4PHP-21 - With thanks to Ion CERTEJAN Entirely your call, it is one of the things we do at other projects in addition to mentions in changes files and contributors sections. It also helps create those changes and contributors sections as in the past I've often gone back through svn logs to see who has contributed and so can mention them properly. Up to you, and hopefully I won't bang on about it any more :) (If you agree I'll alter the log message to suit) Gav... > > > Incorrect params passed in set_include_path > > ------------------------------------------- > > > > Key: LOG4PHP-21 > > URL: https://issues.apache.org/jira/browse/LOG4PHP-21 > > Project: Log4php > > Issue Type: Bug > > Components: Tests > > Environment: Win XP, PHP 5.2.5, Maven 2.0.9, PHPUnit 3.2.17, > Log4php checked out from svn head as of Nov 14th 2008 > > Reporter: Ion CERTEJAN > > Assignee: Knut Urdalen > > Fix For: 2.0 > > > > > > In file: > > log4php/trunk/src/test/php/phpunit.php > > the line (line #33): > > set_include_path(LOG4PHP_DIR.':'.get_include_path()); > > should be replaced with: > > set_include_path(LOG4PHP_DIR.PATH_SEPARATOR.get_include_path()); > > according to http://www.php.net/manual/en/function.set-include-path.php. > > Tests failed on my system because my PATH_SEPARATOR is defined as ';' > (semicolon) > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > > > -- > No virus found in this incoming message. > Checked by AVG. > Version: 7.5.557 / Virus Database: 270.12.4/2082 - Release Date: 4/27/2009 > 6:19 AM
