> Yes, LoggerPropertyGetter can be removed, and we should also try to get rid > of LoggerPropertySetter in my eyes. Utilizing __get() and __set() magic > methods is a little nicer option in PHP 5.
OK at removing Getter. About property setter: we have several other places in code where methods named "factory" and "singleton" exist. They are used for reflective creation of f.e. appender classes. I think those methods should be moved to ReflectionUtils. I am not sure about the __get() and __set() too - this looks like an interceptor in aop style rather more than the normal getter/setter philosphie. Christian >> >> Why not have all core classes in the "root" folder src/main/php/* ? >> > > Yes, let's have all these classes in "root"-folder. > > Knut > >
