Author: grobmeier
Date: Thu May 7 09:29:13 2009
New Revision: 772568
URL: http://svn.apache.org/viewvc?rev=772568&view=rev
Log:
implemented console test
improved syntax
Modified:
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderConsole.php
incubator/log4php/trunk/src/test/php/appenders/LoggerAppenderConsoleTest.php
Modified:
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderConsole.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderConsole.php?rev=772568&r1=772567&r2=772568&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderConsole.php
(original)
+++ incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderConsole.php
Thu May 7 09:29:13 2009
@@ -42,7 +42,7 @@
* Default is STDOUT
* @var string
*/
- protected $target = self::STDOUT;
+ private $target = self::STDOUT;
/**
* @var boolean
@@ -69,12 +69,8 @@
}
}
- public function getTarget() {
- return $this->target;
- }
-
public function activateOptions() {
- $this->fp = fopen($this->getTarget(), 'w');
+ $this->fp = fopen($this->target, 'w');
if($this->fp !== false && $this->layout !== null) {
fwrite($this->fp, $this->layout->getHeader());
}
@@ -92,7 +88,7 @@
$this->closed = true;
}
- protected function append($event) {
+ public function append($event) {
if ($this->fp && $this->layout !== null) {
fwrite($this->fp, $this->layout->format($event));
}
Modified:
incubator/log4php/trunk/src/test/php/appenders/LoggerAppenderConsoleTest.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/test/php/appenders/LoggerAppenderConsoleTest.php?rev=772568&r1=772567&r2=772568&view=diff
==============================================================================
---
incubator/log4php/trunk/src/test/php/appenders/LoggerAppenderConsoleTest.php
(original)
+++
incubator/log4php/trunk/src/test/php/appenders/LoggerAppenderConsoleTest.php
Thu May 7 09:29:13 2009
@@ -24,21 +24,52 @@
*/
class LoggerAppenderConsoleTest extends PHPUnit_Framework_TestCase {
-
- public function testSetTarget() {
- self::markTestIncomplete();
- }
-
- public function testGetTarget() {
- self::markTestIncomplete();
- }
-
- public function testActivateOptions() {
- self::markTestIncomplete();
- }
-
- public function testClose() {
- self::markTestIncomplete();
+
+ public function testSimpleStdOutLogging() {
+ $layout = new LoggerLayoutSimple();
+
+ $event = new LoggerLoggingEvent('LoggerAppenderConsoleTest',
+ new
Logger('mycategory'),
+
LoggerLevel::getLevelWarn(),
+ "my
message");
+
+ $appender = new LoggerAppenderConsole("mylogger");
+ $appender->setTarget('STDOUT');
+ $appender->setLayout($layout);
+ $appender->activateOptions();
+ $appender->append($event);
+ $appender->close();
}
+
+ public function testSimpleStdErrLogging() {
+ $layout = new LoggerLayoutSimple();
+
+ $event = new LoggerLoggingEvent('LoggerAppenderConsoleTest',
+ new
Logger('mycategory'),
+
LoggerLevel::getLevelWarn(),
+ "my
message");
+
+ $appender = new LoggerAppenderConsole("mylogger");
+ $appender->setTarget('STDERR');
+ $appender->setLayout($layout);
+ $appender->activateOptions();
+ $appender->append($event);
+ $appender->close();
+ }
+
+ public function testSimpleDefaultLogging() {
+ $layout = new LoggerLayoutSimple();
+
+ $event = new LoggerLoggingEvent('LoggerAppenderConsoleTest',
+ new
Logger('mycategory'),
+
LoggerLevel::getLevelWarn(),
+ "my
message");
+
+ $appender = new LoggerAppenderConsole("mylogger");
+ $appender->setLayout($layout);
+ $appender->activateOptions();
+ $appender->append($event);
+ $appender->close();
+ }
}
