On Nov 16, 2009, at 1:28 AM, Christian Grobmeier wrote:

Dear all,

its my pleasure to let you know about the first release candidate of Log4PHP.
According to the process, please vote with:


[ ] +1 Yes go ahead an release based on RC1
[ ] -1 No, because...




It can't be "based on RC1", for the vote to be valid, it should be exactly what would be released. That is, I should be able to check the checksum or signature on the release candidate .tar.gz or .zips and see the same value with the final releases. Renaming the archive file would be okay, but nothing internal.

The top level directory on the release candidate is "apache- log4php-2.0.1-SNAPSHOT". Looks like the build was done on the trunk after the "mvn release:release" bumped the trunk version. If you need to rebuild after running "mvn release:release", you can do it on the tag that creates for the release.

The source archive is an exact copy of the release tag except the pom.xml's differ (the release has the post-release versions). It is good to see that no source files were dropped, but it also shows that no generated files (like the docs) were included in the release.

Still checking other things, but that is enough for a -1 on this release candidate.

It may still be possible to build a valid release from the release tag, but if not, you should rename the existing tag to -RC1 using "svn mv" and then reset the version number in pom.xml to 2.0.0-SNAPSHOT.

Reply via email to