[ 
https://issues.apache.org/jira/browse/LOG4PHP-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878498#action_12878498
 ] 

Christian Grobmeier commented on LOG4PHP-110:
---------------------------------------------

Throwable patch will be included in next rv. I wanted to add it now, but ASF 
SVN is down at the moment - so tomorrow

After careful consideration I agree that exception is the way to go, even when 
we have a slight drawback in backwards compatibility.  

However, while code review I have added a TODO in 
LoggerThrowableInforamtion::getStringRepresentation

Vladimir, could you comment this please: 

if ($renderer instanceof LoggerRendererDefault) {
        $renderer = new LoggerRendererException();
}

It feels wrong too me somehow

Next step is the addition of the Mongo Database Appender - thanks for allt he 
work so far!

Christian

> mongo database appender for log4php
> -----------------------------------
>
>                 Key: LOG4PHP-110
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-110
>             Project: Log4php
>          Issue Type: New Feature
>          Components: Code, Documentation, Tests
>    Affects Versions: 2.0
>         Environment: PHP
>            Reporter: Vladimir Gorej
>            Assignee: Christian Grobmeier
>             Fix For: 2.1
>
>         Attachments: src.tgz, throwable.path
>
>
> mongo database appender for log4php with unit test coverage

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to