Hi,

> I'm new to log4php. But I think if someone transfers files to a subfolder, I
> would recommend this proposal:
> http://groups.google.com/group/php-standards/web/psr-0-final-proposal .
> There are some major project like Zend Framework, Symfony, PEAR, Doctrine,
> CakePHP that are implemented (or going to implement) their structure like
> mentioned in the proposal.

one can download log4php and put it into vendor/Apache/logging/log4php
himself. No action needed for the folder structure.

> If you follow the proposal the structure will be look like:
> LoggerAppender.php => Appender/Abstract.php -> class abstract class
> Log4php_Appender_Abstract

wow, isn't this unbelievable ugly and heavy to read? Do you really want to have
new Log4php_Appender_File()
in your code?
PHP 5.3 supports real namespaces and I would rather suggest going with
these and not to break BC when there is a good solution coming.

Btw - I could find the part were Projects name must be part of the class name.


> But this will be a complete reconstruction of the project.

yes.. thats what I hate on this proposal. :-)

> Not sure if your question was going in this direction. But IMHO I would
> recommend to follow the proposal someday.

Why are these guys not recommending to go with namespaces?
I think the directory structure is fine in log4php, just namespaces
would be fine. Which also kills BC and needs to be carefully
considered.

Cheers
Christian

>
> Regards,
> Dominic
>
> On 18/09/10 15:08, Ivan Habunek wrote:
>>
>> I think it may be a good idea to move files with abstract classes and
>> interfaces to their respective directories.
>> i.e. move:
>> - LoggerAppender.php to appenders
>> - LoggerConfigurator.php to configurators
>> - LoggerFilter.php to filters
>> - LoggerLayout.php to layouts
>>
>> This would make the root directory less cluttered.
>> What do you say?
>>
>> Regards,
>> Ivan
>

Reply via email to