LoggerAppenderFile creates empty log files
------------------------------------------
Key: LOG4PHP-130
URL: https://issues.apache.org/jira/browse/LOG4PHP-130
Project: Log4php
Issue Type: Bug
Components: Code
Affects Versions: 2.3
Environment: -
Reporter: igor nadj
Priority: Minor
Fix For: 2.0
My configuration uses LoggerAppenderDailyFile with a date pattern which
includes seconds, the intent is to create a new log file for each error. The
issue I've come across is that at each request it opens the file, then closes
it (writing out the footer) without actually logging any error messages. My
solution is to move the file-creation code to the time when the first log event
is handled.
My pseudo-patch submission:
In LoggerAppenderFile.php
Change
public function activateOptions(){ ... }
to a stub
public function activateOptions(){ }
moving the contents of activateOptions to a new function
protected function open(){
if($this->fp) return;
<code from activateOptions here>
}
where the new function is called at the start of append()
public function append(LoggerLoggingEvent $event) {
if(!$this->fp) $this->open();
<rest of function>
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
