[
http://jira.qos.ch/browse/LBCORE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10788#action_10788
]
Ceki Gulcu edited comment on LBCORE-56 at 10/18/08 9:58 PM:
------------------------------------------------------------
Hello Thilo,
Why do you say that sub-classing AppenderBase can be cumbersome because of the
layout getter/setter? While I agree that that you have to remember to override
the setter/getter for layout of your subclass has a layout, but if it doesn't
have a layout you don't have to do anything.
Nevertheless, I agree that the way the setter/getter in AppenderBase is
implemented can be confusing or even error prone.
was (Author: [EMAIL PROTECTED]):
Hello Thilo,
Why do you say that sub-classing AppenderBase can be cumbersome because of the
layout getter/setter? While I agree that that you have to remember to override
the setter/getter for layout of your subclass has a layout, but if it doesn't
have a layout you don't have to do anything.
Nevertheless, I agree that the way the setter/getter in AppenderBase is
implemented can be confusing or event error prone.
> AppenderBase getLayout returns null
> -----------------------------------
>
> Key: LBCORE-56
> URL: http://jira.qos.ch/browse/LBCORE-56
> Project: logback-core
> Issue Type: Bug
> Components: Appender
> Affects Versions: 0.9.9
> Environment: Linux
> Reporter: Thilo Tanner
> Assignee: Logback dev list
> Priority: Minor
>
> AppenderBase getter and setter for layout aren't abstract. Because the setter
> drops any value and the getter returns null, overriding the class can be very
> cumbersome, if you don't hav access to the source code of AppenderBase.
> Please make the methods abstract or introduce a layout member.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
logback-dev mailing list
logback-dev@qos.ch
http://qos.ch/mailman/listinfo/logback-dev
