[
http://jira.qos.ch/browse/LBCLASSIC-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12397#action_12397
]
Borislav Andruschuk commented on LBCLASSIC-177:
-----------------------------------------------
I've reviewed patch and found the piece of code that's not thread safe. Look at
exceptionRepeatCount variable in appender, It can be modified from several
threads without exclusive access in append method - you got race condition in
this place. Variable should be just converted from class field to method local
variable.
> Provide an appender similar to log4js AsyncAppender
> ---------------------------------------------------
>
> Key: LBCLASSIC-177
> URL: http://jira.qos.ch/browse/LBCLASSIC-177
> Project: logback-classic
> Issue Type: New Feature
> Components: appender
> Affects Versions: unspecified
> Reporter: Torsten Juergeleit
> Assignee: Logback dev list
> Attachments: 0001-Addition-of-AsyncAppender-class-and-tests.patch,
> AsyncAppender.java, AsyncAppender_logback-test.xml,
> AsyncAppenderInitializationTest.java, AsyncAppenderTest.java
>
>
> We're using log4j successfully in financial B2B / B2C web applications for
> years. Now we would like to adopt Logback but therefore we need support for
> an asynchronous appender decorator like log4js AsyncAppender.
> Attached you can find my take on this kind of appender cobbled together from
> ideas and code from various places:
> * http://logging.apache.org/log4j/1.2/xref/org/apache/log4j/AsyncAppender.html
> * http://jira.qos.ch/browse/LBCLASSIC-20
> * http://jira.qos.ch/browse/LBCLASSIC-176
> * http://www.simonsite.org.uk/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
logback-dev mailing list
[email protected]
http://mailman.qos.ch/mailman/listinfo/logback-dev
