[logback-dev] [JIRA] (LOGBACK-940) Sifting appender only removes stale appenders if append() is called

Fri, 24 Jan 2014 10:25:16 -0800

Issue Type: Improvement Improvement
Affects Versions: 1.0.13
Assignee: Logback dev list
Components: logback-core
Created: 24/Jan/14 7:21 PM
Description:

We have a sifting appender (example below) that has a short timeout window in addition to a filter.

Our issue is that the appenders created by the sifter are only being removed when stale if a logging statement makes it through the filter, and hence to SiftingAppenderBase.append().

As this sifter rarely allows logging statements through (our real filter is very restrictive) we sometimes have stale appenders that are open for days.

While we could certainly poke through the AppenderTracker every so often, what about adding optional functionality that would spin up a thread for all SiftingAppenders and at X (configurable) frequency check for, close and remove any stale appenders (such as with AbstractComponentTrackker.removeStaleComponents()).

    <appender name="trace" class="ch.qos.logback.classic.sift.SiftingAppender">
        <timeout>2 minutes</timeout>
        <maxAppenderCount>100</maxAppenderCount>
        <filter class="ch.qos.logback.classic.filter.LevelFilter">
           <level>INFO</level>
           <onMatch>ACCEPT</onMatch>
           <onMismatch>DENY</onMismatch>
        </filter>

        <sift>
            <appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
                <file>log.log</file>
                <append>true</append>
                <encoder>
                    <pattern>%d{MM-dd-yyyy:HH:mm:ss.SSS} [%thread] %-5level %logger{10}->%method\(\):%line r:%X{reqId} S:%X{site} U:%X{user} - %msg%n</pattern>
                    <immediateFlush>false</immediateFlush>
                </encoder>
            </appender>
        </sift>
    </appender>
Project: logback
Labels: siftingAppender
Priority: Minor Minor
Reporter: Jason Klapste
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira 
_______________________________________________
logback-dev mailing list
[email protected]
http://mailman.qos.ch/mailman/listinfo/logback-dev

Reply via email to