Thanks Bill, I'll be sure to adopt this in the future.
On 10/11/06, William A. Rowe, Jr. <[EMAIL PROTECTED]> wrote:
FYI - we typically note Submitted by: submittor <someone somewhere.com> Reviewed by: list of folks who commented We used to have great cvs stock log messages for this. /sigh Bill [EMAIL PROTECTED] wrote: > Author: toback > Date: Wed Oct 11 13:29:40 2006 > New Revision: 462933 > > URL: http://svn.apache.org/viewvc?view=rev&rev=462933 > Log: > Applied patch - Re: http://mail-archives.apache.org/mod_mbox/incubator-lokahi-dev/200610.mbox/[EMAIL PROTECTED] > > Modified: > incubator/lokahi/lokahi/trunk/src/java/org/apache/lokahi/core/api/user/User.java > > Modified: incubator/lokahi/lokahi/trunk/src/java/org/apache/lokahi/core/api/user/User.java > URL: http://svn.apache.org/viewvc/incubator/lokahi/lokahi/trunk/src/java/org/apache/lokahi/core/api/user/User.java?view=diff&rev=462933&r1=462932&r2=462933 > ============================================================================== > --- incubator/lokahi/lokahi/trunk/src/java/org/apache/lokahi/core/api/user/User.java (original) > +++ incubator/lokahi/lokahi/trunk/src/java/org/apache/lokahi/core/api/user/User.java Wed Oct 11 13:29:40 2006 > @@ -463,10 +463,14 @@ > Collection<Project> keepers = new TMCSet<Project>(); > keepers.addAll(oldProjects); > keepers.retainAll(newProjects); > - newProjects.removeAll(keepers); > + if (newProjects != null) > + newProjects.removeAll(keepers); > + > oldProjects.removeAll(keepers); > - u.removeProject(oldProjects); > - u.addProject(newProjects); > + if (!oldProjects.isEmpty()) > + u.removeProject(oldProjects); > + if (newProjects != null) > + u.addProject(newProjects); > } > > public static User store(User u) throws SQLException { > > > > . >
