Hey there, Tair, did you run the tests when you pulled my change. I had a bit of weirdness going on and because I got obsessed with trying to get the delete button to run from unobtrusively from the interface (unsuccessfully :( ) I'd done a few different bits and pieces on my local version I couldn't remember what the original weirdness was, which is why I hadn't contacted you to say I'd finished the tests.
When I pushed, the tests were passing though. Jason On 09/10/2008, at 3:26 AM, AssimovT wrote: > > ok now archived messages are ignored in "sent" the same as for > "unread" messages. > > also Jason fixed the test cases.. thanks Jason! > > > So here are two commits to bring this feature: > > http://github.com/assimovt/lovd-by-less/commit/ > 13caba5fd05fa6b47530de57bd75eb4aa0523a6d > http://github.com/assimovt/lovd-by-less/commit/ > b03edceac0a8cceaf08b7b1a936012fa40a7488a > > Tair > > On Oct 8, 12:38 pm, AssimovT <[EMAIL PROTECTED]> wrote: >> oh thanks for reporting it.. i will fix it today >> >> Tair >> >> On Oct 8, 10:11 am, Fadhli <[EMAIL PROTECTED]> wrote: >> >>> Hi, just looked at the codes for archiving messages. >> >>> I noticed that when we delete a sent message, the one receiving our >>> message also gets deleted. >> >>> I'm not sure if this is correct behaviour or not. Any insights >>> anyone? >> >>> On Oct 7, 9:02 am, AssimovT <[EMAIL PROTECTED]> wrote: >> >>>> May be i just use asserts wrong? I tried testing from the page/ >>>> checking db at the same time and it works fine. >> >>>> any one has ideas? >> >>>> On Oct 3, 1:57 am, Jason Keenan <[EMAIL PROTECTED]> wrote: >> >>>>> Hey there, >> >>>>> I've pulled the change and had a quick look this morning. I'll >>>>> try and look >>>>> into it more over the weekend if I can. Things are a bit hectic. >> >>>>> Just having a quick look before work it looks like >>>>> 'assert_equal :true' >>>>> should be 'assert_equal true' and is returning false >>>>> but haven't looked any futher. >> >>>>> Jason ;) >>>>> On Mon, 29 Sep 2008 14:44:51 -0700 (PDT), AssimovT >>>>> <[EMAIL PROTECTED]> >>>>> wrote: >> >>>>>> Hiya >> >>>>>> Have added the messages archiving capability. It works well, >>>>>> but i >>>>>> miss the little fixes for test cases. Who wants to pull and >>>>>> fix the >>>>>> couple of test cases? >> >>>>> http://github.com/assimovt/lovd-by-less/commit/ >>>>> 13caba5fd05fa6b47530de... >> >>>>>> Cheers, >> >>>>>> Tair. > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Lovd by Less" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/lovdbyless?hl=en Who loves ya baby? -~----------~----~----~----~------~----~------~--~---
