Thanks! You are in the CHANGES now...
The idea here is to allow either a FIXED number of jobs OR expire them
by time. The exiry by time has priority over the FIXED number of jobs...
Which has priority is interesting... some folks want status to hang
around for a MAXIMUM of 10 minutes... some folks want the last 10 jobs...
So I tried to do both.
Patrick
> From [EMAIL PROTECTED] Sun Dec 9 16:30:09 2001
> Date: Mon, 10 Dec 2001 01:30:02 +0100 (MET)
> From: Dejan Ilic <[EMAIL PROTECTED]>
> To: Patrik Powell <[EMAIL PROTECTED]>
> Subject: Some problems with done_jobs
>
> Hi.
> I think there are a couple problems with LPRng 3.8.2 & done_jobs.
>
> First a obvious Cut-n-paste problem in configure.in.
> --------------------------------------------
> --- configure.in.orig Sun Dec 9 20:03:49 2001
> +++ configure.in Sun Dec 9 20:04:20 2001
> @@ -258,7 +258,7 @@
> dnl done_jobs_max_age value
> dnl
> AC_MSG_CHECKING(retain status for jobs less than N seconds old, default 0 - no
>expiry)
> -AC_ARG_WITH(done_jobs,
> +AC_ARG_WITH(done_jobs_max_age,
> [ --with-done_jobs_max_age=N retain job status N seconds, default 0 - no
>expiry],
> DONE_JOBS_MAX_AGE="$withval", DONE_JOBS_MAX_AGE="0",
> )
>
> ---------
> Second, no matter what I give to configure as value in done_jobs &
> done_jobs_max_age, src/Makefile will take default values when I compile it
> on my Solaris-8 server, even after the patch above is applied.
> -
>
> Third, the logic behind is somewhat skew with done_jobs_max_age.
> If you have "jobs_done=0" then you probably don't wan't done_jobs_max_age
> either and should't have to set the parameter. It was quite confusing to
> track down why the job was left when I had done_jobs=0 in my printcap.
>
> CHANGES (and the code) should be updated from
> ..
> This is best explained by:
> On job completion:
> if( (no error && save_when_done)
> || (error && save_on_error)
> || done_jobs > 0 || done_jobs_max_age > 0 ){
> do not remove job
> }
> ..
>
> to this
> ..
> This is best explained by:
> On job completion:
> if( (no error && save_when_done)
> || (error && save_on_error)
> || (done_jobs > 0 && done_jobs_max_age > 0)){
> do not remove job
> }
> ..
>
> Thanks for an excellent LPD.
> Dejan
> UNIT - Link�ping university, Sweden
>
>
-----------------------------------------------------------------------------
YOU MUST BE A LIST MEMBER IN ORDER TO POST TO THE LPRNG MAILING LIST
The address you post from MUST be your subscription address
If you need help, send email to [EMAIL PROTECTED] (or lprng-requests
or lprng-digest-requests) with the word 'help' in the body. For the impatient,
to subscribe to a list with name LIST, send mail to [EMAIL PROTECTED]
with: | example:
subscribe LIST <mailaddr> | subscribe lprng-digest [EMAIL PROTECTED]
unsubscribe LIST <mailaddr> | unsubscribe lprng [EMAIL PROTECTED]
If you have major problems, send email to [EMAIL PROTECTED] with the word
LPRNGLIST in the SUBJECT line.
-----------------------------------------------------------------------------
