a) I think that the treatment of SID index/label in this I-D needs more explanation.
The I-D rightly says that this is either a 3-octet index or 4-octet label but fails to say how the three octets are mapped into a YANG type uint32. The information is in RFC8665 but it took me a while to find it. I think that it needs repeating in this I-D with a reference to RFC8665. Slightly harder is where to put this. I think that it needs to be in the YANG module as a description. Trouble is, there are lots of uint32 where this is relevant. Now if SID were a YANG derived type ..... b) the I-D does not use the same name for bits as RFC8665 does. Where this happens, then I think there should be an explanation e.g. identity lo-bit description ' this bit is referred to as the L-flag in RFC8665 section 5. c) section 1.1 is out of date d) CODE BEGINS I think better as a new paragraph for ease of reference; I see this as common practive e) leaf mt-id if the only valid values are 0 to 127, then this could use a YANG range to reflect that f) range-size likewise if this must be greater than zero, thrm the YANG could reflect that. It could even be a derived type to avoid repetition Tom Petch From: Lsr <lsr-boun...@ietf.org> on behalf of internet-dra...@ietf.org <internet-dra...@ietf.org> Sent: 19 December 2023 21:41 To: i-d-annou...@ietf.org Cc: lsr@ietf.org Subject: [Lsr] I-D Action: draft-ietf-ospf-sr-yang-25.txt Internet-Draft draft-ietf-ospf-sr-yang-25.txt is now available. It is a work item of the Link State Routing (LSR) WG of the IETF. Title: A YANG Data Model for OSPF Segment Routing for the MPLS Data Plane Authors: Yingzhen Qu Acee Lindem Jeffrey Zhang Ing-Wher Chen Name: draft-ietf-ospf-sr-yang-25.txt Pages: 46 Dates: 2023-12-19 Abstract: This document defines a YANG data module that can be used to configure and manage OSPF Extensions for Segment Routing for the MPLS data plane. The IETF datatracker status page for this Internet-Draft is: https://datatracker.ietf.org/doc/draft-ietf-ospf-sr-yang/ There is also an HTML version available at: https://www.ietf.org/archive/id/draft-ietf-ospf-sr-yang-25.html A diff from the previous version is available at: https://author-tools.ietf.org/iddiff?url2=draft-ietf-ospf-sr-yang-25 Internet-Drafts are also available by rsync at: rsync.ietf.org::internet-drafts _______________________________________________ Lsr mailing list Lsr@ietf.org https://www.ietf.org/mailman/listinfo/lsr _______________________________________________ Lsr mailing list Lsr@ietf.org https://www.ietf.org/mailman/listinfo/lsr _______________________________________________ Lsr mailing list Lsr@ietf.org https://www.ietf.org/mailman/listinfo/lsr