Reviewer: Tony Li
Review result: Has Nits
OPSDIR Last Call Review of draft-ietf-lsr-ospf-prefix-extended-flags
Reviewer: Tony Li
Status: Has Nits
Overall: Ready, but with a few nits.
Details:
Section 2:
1)
OLD:
This contains a variable number of 32-bit flags.
NEW:
This contains a variable number of flags, grouped in 4-octet
blocks.
Flags, by definition, are a single bit.
2) You write:
If any trailing 32-bit block(s) are
received without any bit being set in it, then the LSA MUST be
considered malformed.
This seems unnecessarily restrictive. Please consider dropping
it. Postel's Law says that it should be accepted as it is semantically
clear. Operationally, this will improve interoperability.
Section 5.1.1:
OLD:
* Bit number (counting from bit 0 as the most significant
bit)
NEW:
* Bit number (counting from bit 0 as the most significant bit
of the first block)
There is no specification of which way the blocks of bits are ordered
within the TLV. This is a subtle hint that we are consistently being
big-endian. If you would like to be less subtle, I would also suggest
explicit wording in section 2. Repeat this change in section 5.2.1 as
well.
_______________________________________________
Lsr mailing list -- [email protected]
To unsubscribe send an email to [email protected]
