On Mon, 2008-04-14 at 09:21 -0300, Edjunior Barbosa Machado wrote: > Subrata Modak wrote: > > Santwana/Machado, > > > > I remember you also reporting the same Problem. Can you please confirm > > and clarify more ? > > > > Regards-- > > Subrata > > > > On Sun, 2008-04-13 at 20:56 +0300, S.Çağlar Onur wrote: > >> Hi; > >> > >> faccessat01 and fchmodat01 did not test the AT_FDCWD, following patch > >> makes them test AT_FDCWD and pass > >> > >> Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]> > >> > >> diff -ur > >> ltp-full-20080331.orig/testcases/kernel/syscalls/faccessat/faccessat01.c > >> ltp-full-20080331/testcases/kernel/syscalls/faccessat/faccessat01.c > >> --- > >> ltp-full-20080331.orig/testcases/kernel/syscalls/faccessat/faccessat01.c > >> 2008-03-31 10:25:10.000000000 +0300 > >> +++ ltp-full-20080331/testcases/kernel/syscalls/faccessat/faccessat01.c > >> 2008-04-13 20:53:13.000000000 +0300 > >> @@ -196,6 +196,7 @@ > >> fds[0] = fds[1] = fds[4] = dirfd; > >> fds[2] = fd; > >> fds[3] = 100; > >> + fds[5] = AT_FDCWD; > >> > >> filenames[0] = filenames[2] = filenames[3] = filenames[4] = testfile; > >> filenames[1] = testfile2; > >> diff -ur > >> ltp-full-20080331.orig/testcases/kernel/syscalls/fchmodat/fchmodat01.c > >> ltp-full-20080331/testcases/kernel/syscalls/fchmodat/fchmodat01.c > >> --- ltp-full-20080331.orig/testcases/kernel/syscalls/fchmodat/fchmodat01.c > >> 2008-03-31 10:25:10.000000000 +0300 > >> +++ ltp-full-20080331/testcases/kernel/syscalls/fchmodat/fchmodat01.c > >> 2008-04-13 20:52:54.000000000 +0300 > >> @@ -195,6 +195,7 @@ > >> fds[0] = fds[1] = fds[4] = dirfd; > >> fds[2] = fd; > >> fds[3] = 100; > >> + fds[5] = AT_FDCWD; > >> > >> filenames[0] = filenames[2] = filenames[3] = filenames[4] = testfile; > >> filenames[1] = testfile2; > >> > >> > >> Cheers > > > > Hi Subrata, > > yes, we also experienced these same problems in faccessat01 and fchmodat01. > AFAIK, this happened because both faccessat and fchmodat functions didn't set > 'dirfd' argument properly for their last testcases steps, so I think these > patches really should fix these issues. >
So, Would you also like to merge your Patch (that is available to me personally) and this Patch, and give me a version that takes care of issue(s) you and he fixed ?? Or you want me to merge this Patch alone. I prefer the merging of yours and S.Çağlar Onur´s ;-) Regards-- Subrata > Regards, > > Edjunior ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
