Mike, Can you review this ?
Regards--
Subrata
On Wed, Apr 23, 2008 at 11:56 PM, Subrata Modak
<[EMAIL PROTECTED]> wrote:
On Wed, 2008-04-23 at 23:46 -0400, Mike Frysinger wrote:
> On Wednesday 23 April 2008, Garrett Cooper wrote:
> > I discovered some issues with IDcheck.sh dealing with
detection and
> > creation of [GU]ID's and am submitting this patch to
fix /etc/group and UID
> > detection issues, as well as modularize some things.
> >
> > This *should* solve all of the issues involved with
detecting UIDs and
> > GIDs... if only NIS wasn't a factor -- then I don't think
that we'd need to
> > use id(1) at all.
>
> the changelog in the file should be dropped. we have a
scm ... log messages
> go there, not in the file.
>
> the coding style is weird. for example:
> +ife() {
> + id $@ > /dev/null; return $?;
> +}
> that return statement is redundant. the $@ is improperly
quoted. same goes
> for gfe().
>
> + touch /etc/group || {
> + echo "Couldn't touch /etc/group"
> + exit 1
> + }
> use an if statement like normal
>
> + gfe '^nobody:' /etc/passwd
> + if [ $? -ne 0 ] && [ $NO_NOBODY_ID -ne 0 ]; then
> there's no point in splitting the gfe/if statements. inline
these and all the
> others.
Thanks Garrett for you Patch. Can you please modify it with
inputs as
provided by Mike and resend it once again ?
Regards--
Subrata
Ok. How about this patch instead?
Thanks,
-Garrett
IDcheck_sh.patch
Description: Binary data
------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
