On Fri, 2008-04-25 at 18:29 +0200, Renaud Lottiaux wrote: > Le vendredi 25 avril 2008, Sridhar Vinay a écrit : > > > The latest patch includes the patch I had submitted earlier. This covers > > all testcases under "testcases/misc/math/float" dir. > > This patch looks good to me. > > However, I suggest some small modifications (see the attached patch).
Vinay, does this address your issue ? Regards-- Subrata > > * I suggest to built pathname to binaries by looking in the default binary > installation path ($LTPROOT/testcases/bin/) instead of code path > ($LTPROOT/testcases/misc/math/float/...) > > * The path to the generation binaries is build in the main.c file and passed > as an argument to the binaries. Doing this, there is a single point where > the path is built. So, if we need to modify the binary path in the future, > we will just have one file to modify. > > * In the various generation files, I suggest some small modifications in > the pathname building, using only sprintf, making the code cleaner and > easier to read. > > A more general remark: it could be interresting to define a LTP_BIN_PATH > environnement variable. We currently have a LTPROOT path, but we need to > built the path to binaries in the test code, by adding "/testcases/bin". If > one want to modify the installation path for binaries, tests code will have to > be modified... This is quite dirty ! > > Regards. > > R. > > ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
