--- ltp-full-20080731/testcases/kernel/syscalls/ipc/shmat/shmat01.c
2008-05-20 20:42:49.000000000 +1000
+++ ltp-full-20080731/testcases/kernel/syscalls/ipc/shmat/shmat01.c.pcl
2008-08-22 15:02:25.000000000 +1000
@@ -283,7 +283,7 @@
/* some architectures (e.g. parisc) are strange, so better always align
to
* next SHMLBA address. */
- base_addr = (void *)( ((unsigned long)(base_addr) & ~(SHMLBA-1)) +
SHMLBA );
+ base_addr = (void *)( ((unsigned long)(base_addr) + (SHMLBA-1)) &
~(SHMLBA-1));
}
/*
Signed-off-by: Bob Hepple <[EMAIL PROTECTED]>
On Wed, 27 Aug 2008 19:27:22 +0530
Subrata Modak <[EMAIL PROTECTED]> wrote:
> Bob,
>
> Resend me the Patch with a DCO Signoff.
>
> Regards--
> Subrata
>
> On Wed, 2008-08-27 at 06:44 -0700, Cai Qian wrote:
> > --- On Tue, 8/26/08, Bob Hepple <[EMAIL PROTECTED]> wrote:
> >
> > > From: Bob Hepple <[EMAIL PROTECTED]>
> > > Subject: Re: [LTP] Error on shmat01
> > > To: [EMAIL PROTECTED]
> > > Cc: [email protected]
> > > Date: Tuesday, August 26, 2008, 12:06 AM
> > > I'd prefer to wait till other architectures can verify
> > > it.
> > >
> >
> > I could confirmed this patch fixed the problem for me on x86_64 and ppc64.
> >
> > Thanks,
> > CaiQian
> >
> > > I only tried i686
> > >
> > >
> > > Bob
> > >
> > > On Fri, 22 Aug 2008 15:00:34 +0530
> > > Subrata Modak <[EMAIL PROTECTED]> wrote:
> > >
> > > > A patch with Signed-Off-By: Bob Hepple
> > > <[EMAIL PROTECTED]> please.
> > > > Only then i can merge your changes.
> > > >
> > > > Regards--
> > > > Subrata
> > > >
> > > > On Fri, 2008-08-22 at 13:42 +1000, Bob Hepple wrote:
> > > > > On centos-5 2.6.18 kernel, I get a failure with
> > > shmat01:
> > > > >
> > > > > shmat01 1 FAIL : shmat01 call failed -
> > > errno = 22 : Invalid argument
> > > > > shmat01 2 BROK : Remaining cases broken
> > > > > shmat01 3 BROK : Remaining cases broken
> > > > >
> > > > > In the setup() function at the end:
> > > > >
> > > > > /* some architectures (e.g. parisc) are
> > > strange, so better always align to
> > > > > * next SHMLBA address. */
> > > > > base_addr = (void *)( ((unsigned
> > > long)(base_addr) & ~(SHMLBA-1)) + SHMLBA );
> > > > >
> > > > > This bumps up the address if it's already
> > > aligned!!!!!
> > > > >
> > > > > This this line instead:
> > > > > base_addr = (void *)( ((unsigned long)(base_addr)
> > > + (SHMLBA-1)) & ~(SHMLBA-1));
> > > > >
> > > > > it works on all of our i686 systems.
> > > > >
> > > > > Bob
> > > > >
> > > > >
> > >
> > >
> > > --
> > > Bob Hepple <[EMAIL PROTECTED]>
> > > ph: 07-5584-5908 Fx: 07-5575-9550
> > >
> > > -------------------------------------------------------------------------
> > > This SF.Net email is sponsored by the Moblin Your Move
> > > Developer's challenge
> > > Build the coolest Linux based applications with Moblin SDK
> > > & win great prizes
> > > Grand prize is a trip for two to an Open Source event
> > > anywhere in the world
> > > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > > _______________________________________________
> > > Ltp-list mailing list
> > > [email protected]
> > > https://lists.sourceforge.net/lists/listinfo/ltp-list
> >
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win great
> > prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > Ltp-list mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/ltp-list
--
Bob Hepple <[EMAIL PROTECTED]>
ph: 07-5584-5908 Fx: 07-5575-9550
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
