Quoting Sudhir Kumar ([email protected]):
> This patchset creates the basic infrastructure for running the existing
> network
> testcases under containers automatically. The patchset creates a command file
> named nw_under_ns for the purpose.
> Please review them and provide all your valuable feedback.
> I have addressed all the comments from lxc-dev list except one.
>
> The changelog looks like:
> 1. Added verbose comments and patch description.
> 2. Restructured the licensing text.
> 3. Merged two patches into one touching runallnetworktest_child.sh file.
>
> TODO:
> 1. Changing the kernel version to proper one
> 2. unshare not needed as clone only is suffucient. I will do it in a
> separate patch as need to do extensive testing to ensure other testcases
> do not break.
It actually might be worth doing the tests twice,
. Once with just clone() and including CLONE_NEWPID
. Once with just unshare() and not including CLONE_NEWPID
since it is not supported by unshare
The unshare and clone paths are subtly different and bugs to
crop up from time to time.
So overall I think the approach we should take, for logistical
reasons, is to push this patchset early, and if I make any comments
about todos, address those in follow-on patches. It should be the
case that these tests won't automatically run - since netns isn't
supported in anyoen's kernels until 2.6.29 - so it shouldn't be
unsafe. Of course it's up to Subrata whether that is acceptable.
I'll go through the set today and plan to be pretty liberal with acks.
thanks,
-serge
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
