> > I'm passing NULL to tst_brkm, so we should never enter this code. But > > tst_brkm() calls tst_exit() in some circumstances so we should either add > > __atribute__ ((noreturn)) to tst_brkm too or remove tst_exit() from it. > > > > OK. How about we do, > > tst_resm(TCONF, "libaio missing"); > tst_exit(); > > instead of, > > tst_brkm(TCONF, NULL, "libaio missing"); > tst_exit(); > > since I can't see the reason to use tst_brkm() in this case?
Sounds reasonable for this case, but I still think we should rethink which tst_* functions calls exit() or tst_exit() and if they needs __attribute__ ((noreturn)). -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ OpenSolaris 2009.06 is a cutting edge operating system for enterprises looking to deploy the next generation of Solaris that includes the latest innovations from Sun and the OpenSource community. Download a copy and enjoy capabilities such as Networking, Storage and Virtualization. Go to: http://p.sf.net/sfu/opensolaris-get _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
