On Thu, 2009-08-20 at 09:57 -0700, Garrett Cooper wrote: 
> On Thu, Aug 20, 2009 at 9:08 AM, Poornima
> Nayak<[email protected]> wrote:
> > This is the new tescase to test timer migration interface.
> >
> > Signed-off-by: poornima nayak <[email protected]>
> >
> > diff -uprN 
> > ltp-full-20090731_orig/testcases/kernel/power_management/test_timer_migration.sh
> >  ltp-full-20090731/testcases/kernel/power_management/test_timer_migration.sh
> > --- 
> > ltp-full-20090731_orig/testcases/kernel/power_management/test_timer_migration.sh
> >     1970-01-01 05:30:00.000000000 +0530
> > +++ 
> > ltp-full-20090731/testcases/kernel/power_management/test_timer_migration.sh 
> > 2009-08-20 20:49:48.000000000 +0530
> > @@ -0,0 +1,22 @@
> > +#!/bin/bash
> > +
> > +. pm_include.sh
> > +
> > +valid_input="0 1"
> > +invalid_input="3 4 5 6 7 8 a abcefg x1999 xffff -1 -00000
> > +200000000000000000000000000000000000000000000000000000000000000000000000000000
> > +ox324 -0xfffffffffffffffffffff"
> > +test_file="/proc/sys/kernel/timer_migration"
> > +if [ ! -f ${test_file} ] ; then
> > +       echo "MISSING_FILE: missing file ${test_file}"
> > +       exit $MISSING_FILE
> > +fi
> > +
> > +RC=0
> > +echo "${0}: ---Valid test cases---"
> > +check_input "${valid_input}" valid $test_file
> > +RC=$?
> > +echo "${0}: ---Invalid test cases---"
> > +check_input "${invalid_input}" invalid $test_file
> > +RC=$(( RC | $? ))
> > +exit $RC
> 
> 1. Please replace
> 
> ${0}
> 
> with:
> 
> ${0##*}
> 
> 2. Wouldn't it make more sense to say `exit $(( RC | $? )'?
> 

Poornima,

Can you also please address them in a new patch ?

Regards--
Subrata

> Thanks,
> -Garrett
> 
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> trial. Simplify your report design, integration and deployment - and focus on 
> what you do best, core application coding. Discover what's new with 
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Ltp-list mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ltp-list


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to