On Wed, Feb 17, 2010 at 7:02 AM, Rishikesh K Rajak <[email protected]> wrote: > On Mon, Feb 15, 2010 at 03:33:37PM +0900, Yuki Yao wrote: >> Hi, >> >> I contributed following problem previously, but it's not yet revised. >> So, I contribute this again. >> >> After "./runltp" execution, all log files such as "/var/log/messages*" >> disappeared, and there is only new log file created after the test. >> >> This seems a problem that occurs after the "logrotate01" test. >> I found that the past log files were deleted by forcing a "logrotate" >> (logrotate -fv $LTPTMP/tst_logrotate.conf). >> >> Besides, logrotate01's shell script "./testcases/commands/logrotate >> /logrotate_tests.sh" creats logrotate configuration file ($LTPTMP >> /tst_logrotate.conf) for the test, and this configration file includes >> "/etc/logrotate.d" as follows: >> >> [ ./testcases/commands/logrotate/logrotate_tests.sh line:156~ ] >> ---------- >> # create config file. >> cat >$LTPTMP/tst_logrotate.conf <<-EOF >> #****** Begin Config file ******* >> # create new (empty) log files after rotating old ones >> create >> >> # compress the log files >> compress >> >> # RPM packages drop log rotation information into this directory >> include /etc/logrotate.d >> >> /var/log/tst_logfile { >> rotate 5 >> weekly >> } >> #****** End Config file ******* >> EOF >> ---------- >> >> By This, not only a log file for the test (/var/log/tst_logfile) >> but also 30 fies such as "/var/log/messages*" become "logrotate" >> command target. >> Only a log file for this test must become a target of the forced >> execution of "logrotate". >> >> To resolve this problem, we must change "/logrotate_tests.sh" not to >> include "/etc/logrotate.d", I think. >> >> Signed-off-by: Yuki Yao<[email protected]> > > Hello Garret, > > Any input for this patch ? > > Thanks > -Rishi >> >> Index: ./testcases/commands/logrotate/logrotate_tests.sh >> ============ >> --- ./testcases/commands/logrotate/logrotate_tests.sh.orig 2008-10-21 >> 15:54:15.000000000 +0900 >> +++ ./testcases/commands/logrotate/logrotate_tests.sh 2010-02-15 >> 13:32:02.000000000 +0900 >> @@ -163,7 +163,7 @@ >> compress >> >> # RPM packages drop log rotation information into this directory >> - include /etc/logrotate.d >> + # include /etc/logrotate.d >> >> /var/log/tst_logfile { >> rotate 5 >> @@ -200,7 +200,7 @@ >> # check if /etc/logrotate.d is included/ >> # check if 5 rotations are forced. >> # check if compression is done. >> - grep "including /etc/logrotate.d" $LTPTMP/tst_logrotate.out >> \ >> + # grep "including /etc/logrotate.d" >> $LTPTMP/tst_logrotate.out \ >> > $LTPTMP/tst_logrotate.err 2>&1 || RC=$? >> grep "reading config file $LTPTMP/tst_logrotate.conf" \ >> $LTPTMP/tst_logrotate.out > >> $LTPTMP/tst_logrotate.err 2>&1 || RC=$? >> ============
The problem statement isn't clearly worded, thus I'm confused whether or not the patch is fixing a symptom or the root cause itself. Thanks, -Garrett ------------------------------------------------------------------------------ SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
