On Thu, Aug 5, 2010 at 9:38 AM, Garrett Cooper <[email protected]> wrote:
> On Thu, Aug 5, 2010 at 8:57 AM, Mike Frysinger <[email protected]> wrote:
>> On Thursday, August 05, 2010 09:54:50 Garrett Cooper wrote:
>>> On Aug 5, 2010, at 6:53 AM, Cyril Hrubis wrote:
>>> >> BTW... calling 1make' bareword never worked with 3.80; all of the the
>>> >> directions in INSTALL say use make all [...]; make install. The reason
>>> >> being is that make 3.80 didn't have a functional .DEFAULT_GOAL
>>> >> equivalent until sometime around midway between make 3.80 and make
>>> >> 3.81; so assuming that `make' will function the same as `make all'
>>> >> isn't a good assumption to make :).
>>> >
>>> > So ltp buildsystem is kind of a mine field ;). Anyway as make picks up
>>> > first target and makes it default adding "default: all" to the beginning
>>> > of env_pre.mk seems to fix that problem for me.
>>>
>>> Seems like a decent workaround for cases when env_pre.mk is used, but this
>>> isn't possible with 3rd party Makefiles, so it might be kind of a moot
>>> point.
>>>
>>> Just to be safe I'd stick with the directions unless you want to submit
>>> patches to fix every issue in the source tree :)...
>>
>> tweaking the top level makefile so the standard `./configure && make` works
>> without having to read directions would be nice
>
> Ok, fair enough :)... please try the attached patch, and if it
> works for you I'll commit it. File bugs or send patches if you find
> any issues beyond the top-level Makefile.
> Thanks,
> -Garrett
>
> diff --git a/include/mk/env_pre.mk b/include/mk/env_pre.mk
> index 4444124..17a91fa 100644
> --- a/include/mk/env_pre.mk
> +++ b/include/mk/env_pre.mk
> @@ -124,8 +124,13 @@ BUILD_TREE_STATE :=
> $(BUILD_TREE_NONSRCDIR_INSTAL
> endif
> endif
>
> -# make 3.80 called it .DEFAULT_TARGET.
> +ifeq ($(MAKE_3_80_COMPAT),1
> +# Trick make 3.80 into thinking that the default goal is all.
> +.PHONY: default
> +default: all
> +else
> .DEFAULT_GOAL := all
> +endif
>
> endif # END autotools, *clean...
I committed the patch to HEAD. Let me know whether or not it
works; it might not work because `include' creates a pseudo target,
but please let me know if it works or not.
Thanks!
-Garrett
------------------------------------------------------------------------------
This SF.net email is sponsored by
Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
