On Wed, Sep 15, 2010 at 6:43 AM, Hannu Heikkinen
<[email protected]> wrote:
> On 14/09/10 06:39 +0200, ext Mitani wrote:
>> Hi,
>>
>> POSIX "open_posix_testsuite/conformance/interfaces/sched_yield/1-1.c"
>> build failed in RHEL4.8 (x86, x86_64, ia64):
>> ------------
>> conformance/interfaces/sched_yield/1-1 compile FAILED; SKIPPING In file
>> included from ../../../conformance/interfaces/sched_yield/1-1.c:35:
>> ../../../include/posixtest.h:14:2: #error "Contains GNU-isms that need
>> fixing."
>> ../../../conformance/interfaces/sched_yield/1-1.c: In function
>> `set_thread_affinity':
>> ../../../conformance/interfaces/sched_yield/1-1.c:91: warning: implicit
>> declaration of function `pthread_setaffinity_np'
>> ------------
>>
>> This testset seems to test "sched_yield()", and uses "sched_setafinity()"
>> for CPU fixing.
>> I tried to remove "_GNU_SOURCE" definition from "sched_yield/1-1.c".
>> But "sched_setafinity()" needs "_GNU_SOURCE".
>> "sched_setafinity()" is necessary for this testset, and I considered the
>> substitution for "sched_setafinity()".
>> But I don't have any ideas. There is no function to be substitute for
>> "sched_setafinity()" by POSIX conformity, I think.
>>
>>
>> Regards--
>>
>> -Tomonori Mitani
>>
>
> Hi,
>
> could try this out?
>
> --- include/posixtest.h 2010-09-14 14:05:21.000000000 +0000
> +++ fixing/posixtest.h  2010-09-14 19:01:02.000000000 +0000
> @@ -11,8 +11,16 @@
>  */
>
>  #if defined(_GNU_SOURCE)
> +#if defined (PTS_GNU_SOURCE_WARNING)
> +#warning "Contains GNU-isms that need fixing."
> +#else
>  #error "Contains GNU-isms that need fixing."
> +#endif
> +
>  #elif defined(_BSD_SOURCE)
> +#if defined (PTS_BSD_SOURCE_WARNING)
> +#warning "Contains BSD-isms that need fixing."
> +#else
>  #error "Contains BSD-isms that need fixing."
>  #endif
>
>
> Add to yr source #define PTS_GNU_SOURCE_WARNING 1
> and compile, or define in posixtest.h and include that hdr.

That seems like a reasonable thing to do, but here's an alternative
way to do this (less variables):

--- a/testcases/open_posix_testsuite/include/posixtest.h
+++ b/testcases/open_posix_testsuite/include/posixtest.h
@@ -10,10 +10,24 @@
  * return codes
  */

+/*
+ * Define PTS_DEVELOPER_MODE if you want to compile for developer scenarios,
+ * including reporting errors (as opposed to warnings), when compiling some
+ * test programs.
+ */
+
 #if defined(_GNU_SOURCE)
+#if defined(PTS_DEVELOPER_MODE)
 #error "Contains GNU-isms that need fixing."
+#else
+#warning "Contains GNU-isms that need fixing."
+#endif
 #elif defined(_BSD_SOURCE)
+#if defined(PTS_DEVELOPER_MODE)
 #error "Contains BSD-isms that need fixing."
+#else
+#warning "Contains BSD-isms that need fixing."
+#endif
 #endif

 #define PTS_PASS        0

Thanks for the idea Hannu :),
-Garrett

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to