On Tue, Sep 14, 2010 at 10:10 AM, Scott Romanowski <[email protected]> wrote: > Garrett Cooper <[email protected]> wrote on 09/14/2010 12:43:47 PM: >> 1. It doesn't make sense why you're doing this, unless you're >> purposely trying to impose a limit to get the consumer to fail on the >> next round. What happens if you make this 0 instead? > > You're right; this should be 0. I foolishly just copied the structure from > the functions above.
Ok. >> 2. Also, have you tried inverting the logic to test out whether or not >> this case functions as expected (i.e. #ifndef __linux__ ... #else >> return (size_t) -1; #endif)? >> 3. This also exposes type bugs in the tests; example: > > I didn't test the LTP on a non-Linux platform. I'm new to this, sorry. I would just remove the __linux__ check because hugepages are a Linux-only feature. Thanks, -Garrett ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
