Hi, this is the patch with the description. Btw please reply to me if anything not appropriate. I'm not involved in the [email protected]
commit bb43a35ce70ad638f72ae7dcd8c198ca95dac43f Author: Xu,Anhua <[email protected]> Date: Wed Feb 8 11:04:33 2012 +0800 Power Management: fix configuration check for sched_domain.py Add checking for "sched_debug" in kernel cmdline parameter. Without this option, power policy change via sched_mc/smt_power_savings will not cause any output from dmesg that is needed for sched_domain.py diff --git a/testcases/kernel/power_management/runpwtests.sh b/testcases/kernel/power_management/runpwtests.sh index c4a1d39..ab4536f 100755 --- a/testcases/kernel/power_management/runpwtests.sh +++ b/testcases/kernel/power_management/runpwtests.sh @@ -188,8 +188,11 @@ fi # sched_domain test if ! type python > /dev/null ; then - tst_resm TCONF "Python is not installed, CPU Consoldation\ + tst_resm TCONF "Python is not installed, CPU Consolidation\ test cannot run" +elif ! grep sched_debug -qw /proc/cmdline ; then + tst_resm TCONF "Kernel cmdline parameter 'sched_debug' needed,\ +CPU Consolidation test cannot run" else if [ -f /sys/devices/system/cpu/sched_mc_power_savings ] ; then echo "max sched mc $max_sched_mc" -----Original Message----- From: Cyril Hrubis [mailto:[email protected]] Sent: Wednesday, February 01, 2012 11:26 PM To: Xu, Anhua Cc: Garrett Cooper; Song, Youquan; [email protected] Subject: Re: [Ltp-commits] [patch] Power Management: add notification once 'sched_debug' not in boot cmdline Hi! > Thanks for the reminding. Besides, I changed it as a "TCONF" like > below for prerequisite for CPU consolidation. That is more > illustrative. > And also fix a little typo for "Consolidation" :) . > > Anything not appropriate, please free to let me knows. Looks good, please send signed patch with reasonable description to be applied to the git repository. > diff --git a/testcases/kernel/power_management/runpwtests.sh > b/testcases/kernel/power_management/runpwtests.sh > index c4a1d39..ab4536f 100755 > --- a/testcases/kernel/power_management/runpwtests.sh > +++ b/testcases/kernel/power_management/runpwtests.sh > @@ -188,8 +188,11 @@ fi > > # sched_domain test > if ! type python > /dev/null ; then > - tst_resm TCONF "Python is not installed, CPU Consoldation\ > + tst_resm TCONF "Python is not installed, CPU Consolidation\ > test cannot run" > +elif ! grep sched_debug -qw /proc/cmdline ; then > + tst_resm TCONF "Kernel cmdline parameter 'sched_debug' needed,\ > +CPU Consolidation test cannot run" > else > if [ -f /sys/devices/system/cpu/sched_mc_power_savings ] ; then > echo "max sched mc $max_sched_mc" -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
