On 02/08/2012 04:47 PM, Wanlong Gao wrote:
> On 02/08/2012 04:39 PM, Caspar Zhang wrote:
> 
>> On 02/08/2012 04:21 PM, Wanlong Gao wrote:
>>> diff --git a/runtest/hugetlb b/runtest/hugetlb
>>> index a316043..2cbd410 100644
>>> --- a/runtest/hugetlb
>>> +++ b/runtest/hugetlb
>>> @@ -1,4 +1,4 @@
>>> -hugemmap01 hugemmap01 -H/tmp
>>> +hugemmap01 hugemmap01
>>>  hugemmap02 hugemmap02 -H/tmp -c10
>>>  hugemmap03 hugemmap03 -H/tmp -I2 -c10
>>>  hugemmap04 hugemmap04 -H/tmp
>>> diff --git a/testcases/kernel/mem/hugetlb/hugemmap/Makefile 
>>> b/testcases/kernel/mem/hugetlb/hugemmap/Makefile
>>> index a1ba46e..eb1f52a 100644
>>> --- a/testcases/kernel/mem/hugetlb/hugemmap/Makefile
>>> +++ b/testcases/kernel/mem/hugetlb/hugemmap/Makefile
>>
>> [snip]
>>
>>>  static int hugepagesmapped;
>>> +static long hugepages = 1024;
>>>  
>>
>> Also, the default size 1024 make me feel a little worry. For those
>> systems have a tight memory resource and/or those systems with a large
>> default HPAGE_SIZE (e.g. ppc64 in 16MB), hugepage allocation would fail.
>> Do we have a best solution for it?
> 
> 
> If fail, then the test people should change the setting by passing a "-s" 
> option
> him/her self.
> 
> I don't have a better idea, best solution may be on some future ;)

I'd suggest give a smaller value (like, hugemmap05 uses 128) which would
be safer to pass the test, because that most people run the tests are
for general purpose, they don't care how many hugepages *must* be
allocated. (Of course, that will make you change the test with -s option
if you need 1024 pages). Thoughts?

Thanks,
Caspar

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to