> -----Original Message----- > From: Caspar Zhang [mailto:[email protected]] > Sent: Wednesday, February 15, 2012 11:24 AM > To: Filippo ARCIDIACONO > Cc: [email protected] > Subject: Re: [LTP] [PATCH] getrusage03: add opportunity to reduce > memory allocation's size > > On 02/15/2012 04:27 PM, Filippo ARCIDIACONO wrote: > >>> > > static void inherit_fork2(void) > >>> > > { > >>> > > tst_resm(TINFO, "Testcase #02: fork inherit(cont.)"); > >>> > > > >>> > > SAFE_GETRUSAGE(cleanup, RUSAGE_CHILDREN, &ru); > >>> > > tst_resm(TINFO, "initial.children = %ld", ru.ru_maxrss); > >>> > > - if (is_in_delta(ru.ru_maxrss - 102400)) > >>> > > - tst_resm(TPASS, "initial.children ~= 100MB"); > >>> > > + if (is_in_delta(ru.ru_maxrss - (10240 * factor_nr))) > >>> > > + tst_resm(TPASS, "initial.children ~= %dMB", size); > >> > > >> > `size` in this function is not initialized? > > 'size' is globally defined, it is initialized in the main(). > > > > Yes, but seems that you missed a "size = 10240 * factor_nr" here.
No, size is in MB. What I'm doing is pass to inherit_fork2() 'size' as parameter, In this function is used only to format the output string. I'm going to repost the reworked patch shortly. > > Thanks, > Caspar ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
