On Mar 16, 2012, at 1:04 AM, Wanlong Gao <[email protected]> wrote:
> On 03/16/2012 03:58 PM, Peng Haitao wrote: > >> There are 2 changes in this patch. >> 1. Initialize the aiocb struct before using it. >> 2. If Prioritized Input and Output option is supported, submit the >> aiocb with invalid aio_reqprio, else submit the aiocb with invalid >> aio_fildes >> >> Signed-off-by: Peng Haitao <[email protected]> > > > Looks good to me , Cyril? Why not always set fildes == -1 and test that way? >> .../conformance/interfaces/aio_read/8-1.c | 14 ++++++++------ >> .../conformance/interfaces/aio_write/6-1.c | 16 >> +++++++++------- >> 2 files changed, 17 insertions(+), 13 deletions(-) >> >> diff --git >> a/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c >> b/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c >> index 8054eeb..009aeb2 100644 >> --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c >> +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c >> @@ -14,7 +14,9 @@ >> * >> * method: >> * >> - * - fill in an aiocb with a NULL aio_buf >> + * - if Prioritized Input and Output option is supported, fill in an >> + * aiocb with invalid aio_reqprio, else submit the aiocb with invalid >> + * aio_fildes >> * - call aio_read >> * - check aio_read return value >> */ >> @@ -41,11 +43,11 @@ int main() >> if (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L) >> return PTS_UNSUPPORTED; >> >> - /* submit a request with a NULL buffer */ >> - aiocb.aio_fildes = 0; >> - aiocb.aio_buf = NULL; >> - aiocb.aio_nbytes = 0; >> - aiocb.aio_offset = 0; >> + memset(&aiocb, 0, sizeof(struct aiocb)); >> + if (sysconf(_SC_PRIORITIZED_IO) < 200112L) >> + aiocb.aio_fildes = -1; >> + else >> + aiocb.aio_reqprio = -1; >> >> if (aio_read(&aiocb) != -1) { >> printf(TNAME " aio_read() should fail!\n"); >> diff --git >> a/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c >> b/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c >> index 98b8d0d..9234fe6 100644 >> --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c >> +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c >> @@ -14,7 +14,9 @@ >> * >> * method: >> * >> - * - fill in an aiocb with a NULL aio_buf >> + * - if Prioritized Input and Output option is supported, fill in an >> + * aiocb with invalid aio_reqprio, else submit the aiocb with invalid >> + * aio_fildes >> * - call aio_write >> * - check aio_write return value >> * >> @@ -42,11 +44,11 @@ int main() >> if (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L) >> return PTS_UNSUPPORTED; >> >> - /* submit a request with a NULL buffer */ >> - aiocb.aio_fildes = 0; >> - aiocb.aio_buf = NULL; >> - aiocb.aio_nbytes = 0; >> - aiocb.aio_offset = 0; >> + memset(&aiocb, 0, sizeof(struct aiocb)); >> + if (sysconf(_SC_PRIORITIZED_IO) < 200112L) >> + aiocb.aio_fildes = -1; >> + else >> + aiocb.aio_reqprio = -1; >> >> if (aio_write(&aiocb) != -1) >> { >> @@ -62,4 +64,4 @@ int main() >> >> printf ("Test PASSED\n"); >> return PTS_PASS; >> -} >> \ No newline at end of file >> +} > > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > Ltp-list mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ltp-list ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
