On Mon, May 28, 2012 at 4:39 AM, Jan Stancek <[email protected]> wrote: > > A library to share NUMA helper functions shared by > multiple testcases. > > Signed-off-by: Jan Stancek <[email protected]>
One comment... + tst_resm(TFAIL, "get_allowed_nodes, i >= num_allowed_nodes: " + "%d > %d", i, num_nodes); 1. I would just remove this because it's obvious from the API definition what's going on when it sets ret to -3. 2. I would add a break there so it doesn't iterate through the loop more than necessary. Cheers, -Garrett ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
