without the patch, ksm/ksm0* always failed like such below: ... ksm03 0 TINFO : check! ksm03 0 TINFO : run is 1. ksm03 0 TINFO : pages_shared is 2. ksm03 0 TINFO : pages_sharing is 95998. ksm03 1 TFAIL : pages_sharing is not 98302. ksm03 0 TINFO : pages_volatile is 0. ksm03 0 TINFO : pages_unshared is 0. ksm03 0 TINFO : sleep_millisecs is 0. ksm03 0 TINFO : pages_to_scan is 98304. ...
This failure is because of ksm daemon can't finish to scan all mergeable pages, especially occurred in a small/dull system, and commit 366a92805fc9a5b0 ever did partially repair, but can't completely fix the issue, so I added _wait_ksmd_done function, which can give enough time to ksmd scan all mergeable pages. Signed-off-by: Zhouping Liu <z...@redhat.com> --- testcases/kernel/mem/lib/mem.c | 72 +++++++++++++++++++++++++++++++--------- 1 file changed, 57 insertions(+), 15 deletions(-) Hi, Wanlong I have tested the patch set in my lab, and I can't find the issue again: http://sourceforge.net/mailarchive/message.php?msg_id=29088640 could you test/have a look at the patch? diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c index b031184..5ead938 100644 --- a/testcases/kernel/mem/lib/mem.c +++ b/testcases/kernel/mem/lib/mem.c @@ -147,27 +147,69 @@ static void _check(char *path, long int value) tst_resm(TFAIL, "%s is not %ld.", path, value); } -static void _group_check(int run, int pages_shared, int pages_sharing, - int pages_volatile, int pages_unshared, - int sleep_millisecs, int pages_to_scan) +static void _wait_ksmd_done(void) { char buf[BUFSIZ]; - long old_num, new_num; + long run, pages_shared, pages_sharing, pages_volatile, pages_unshared; + long old_run = 0, old_pages_shared = 0, old_pages_sharing = 0, + old_pages_volatile = 0, old_pages_unshared = 0; + long tmp; + int changed = 1, count = 0; + + while(changed) { + while(sleep(5)) + continue; + + changed = 0; + count++; + + read_file(PATH_KSM "run", buf); + run = SAFE_STRTOL(cleanup, buf, LONG_MIN, LONG_MAX); + if (run != old_run) { + old_run = run; + changed = 1; + } - /* 1 seconds for ksm to scan pages. */ - while (sleep(1) == 1) - continue; + read_file(PATH_KSM "pages_shared", buf); + pages_shared = SAFE_STRTOL(cleanup, buf, LONG_MIN, LONG_MAX); + if (pages_shared != old_pages_shared) { + old_pages_shared = pages_shared; + changed = 1; + } + + read_file(PATH_KSM "pages_sharing", buf); + pages_sharing = SAFE_STRTOL(cleanup, buf, LONG_MIN, LONG_MAX); + if (pages_sharing != old_pages_sharing) { + old_pages_sharing = pages_sharing; + changed = 1; + } + + read_file(PATH_KSM "pages_volatile", buf); + pages_volatile = SAFE_STRTOL(cleanup, buf, LONG_MIN, LONG_MAX); + if (pages_volatile != old_pages_volatile) { + old_pages_volatile = pages_volatile; + changed = 1; + } - read_file(PATH_KSM "full_scans", buf); - /* wait 3 increments of full_scans */ - old_num = SAFE_STRTOL(cleanup, buf, 0, LONG_MAX); - new_num = old_num; - while (new_num < old_num * 3) { - sleep(1); - read_file(PATH_KSM "full_scans", buf); - new_num = SAFE_STRTOL(cleanup, buf, 0, LONG_MAX); + read_file(PATH_KSM "pages_unshared", buf); + pages_unshared = SAFE_STRTOL(cleanup, buf, LONG_MIN, LONG_MAX); + if (pages_unshared != old_pages_unshared) { + old_pages_unshared = pages_unshared; + changed = 1; + } } + tst_resm(TINFO, "ksm daemon takes %ds to scan all " + "mergeable pages", count * 5); +} + +static void _group_check(int run, int pages_shared, int pages_sharing, + int pages_volatile, int pages_unshared, + int sleep_millisecs, int pages_to_scan) +{ + /* wait for ksm daemon to scan all mergeable pages. */ + _wait_ksmd_done(); + tst_resm(TINFO, "check!"); _check("run", run); _check("pages_shared", pages_shared); -- 1.7.10.2 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
