On Aug 8, 2012, at 2:29 AM, Caspar Zhang wrote:
> On 07/31/2012 11:57 AM, Garrett Cooper wrote:
>> On Mon, Jul 30, 2012 at 7:53 PM, Caspar Zhang <[email protected]> wrote:
>>>
>>> some NUMA related syscalls: mbind, get_mempolicy are not supported on
>>> some arches (e.g. i386), I use TEST macro to test the syscall in setup()
>>> function, if the syscall is not implemented on the system, a TCONF
>>> message will given like this:
>>>
>>> get_mempolicy01 1 TCONF : syscall __NR_get_mempolicy01 not supported
>>> on your arch
>>
>> Using TEST isn't necessary to be honest: the syscall wrapper
>> handles the (if you add a comment as to why things are being done in a
>> single line, untested, that should be ok).
>> Thanks!
>> -Garrett
>>
>
> Hi Garrett, sorry I'm kind of not catching you :-( what's your suggestion of
> correcting/improving this message?
I'd remove "TEST(..)" from the line and just use the syscall function
call.
If you want, we can make syscall more explicit as far as a custom
wrapper goes.
Cheers!
-Garrett
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
