----- Original Message -----
> From: "DAN LI" <[email protected]>
> To: "Jan Stancek" <[email protected]>
> Cc: "LTP list" <[email protected]>
> Sent: Wednesday, 29 May, 2013 12:25:45 PM
> Subject: Re: [LTP] [PATCH] shmget/shmget01.c: cleanup and attach 
> SHM_NORESERVE to shmflg
> 
> On 05/29/2013 05:18 PM, Jan Stancek wrote:
> > 
> > ----- Original Message -----
> >> From: "DAN LI" <[email protected]>
> >> To: "LTP list" <[email protected]>
> >> Sent: Wednesday, 29 May, 2013 10:58:47 AM
> >> Subject: [LTP] [PATCH] shmget/shmget01.c: cleanup and attach SHM_NORESERVE
> >> to shmflg
> >>
> >>
> >> 1. Remove useless comments
> >>
> >> 2. Revise code to follow ltp-code-style
> >>
> >> 3. Add SHM_NORESERVE to shmflg to test
> > 
> > Can you add some description why you are adding this flag?
> 
> Actually, we are trying to complete test cases and expand
> the test scope of LTP.
> 
> So, it is just for completeness of this case.

My concern here is:
So if we add this flag, we cover SHM_NORESERVE path.
Do we have a testcase which still covers current non-SHM_NORESERVE path?

Regards,
Jan

> 
> Regards,
> DAN LI
> 
> > 
> >>
> >> Signed-off-by: DAN LI <[email protected]>
> >> ---
> > 
> > 
> 
> 
> 

------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to