Hi! On 09/25/2013 09:02 PM, [email protected] wrote: > Hi! >> Makefile example: >> >> top_srcdir ?= ../../../.. >> >> include $(top_srcdir)/include/mk/testcases.mk >> >> REQ_VERSION_MAJOR := 2 >> REQ_VERSION_PATCH := 6 >> >> MODULE_NAMES := Module01 Module02 ... >> MAKE_TARGETS := test01 test02 ... >> >> include $(top_srcdir)/include/mk/module.mk >> include $(top_srcdir)/include/mk/generic_leaf_target.mk > Looks good. > >> --- >> include/mk/module.mk | 69 >> ++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 files changed, 69 insertions(+), 0 deletions(-) >> create mode 100644 include/mk/module.mk >> >> diff --git a/include/mk/module.mk b/include/mk/module.mk >> new file mode 100644 >> index 0000000..9304e4c >> --- /dev/null >> +++ b/include/mk/module.mk >> @@ -0,0 +1,69 @@ >> +# Copyright (c) 2013 Oracle and/or its affiliates. All Rights Reserved. >> +# >> +# This program is free software; you can redistribute it and/or >> +# modify it under the terms of the GNU General Public License as >> +# published by the Free Software Foundation; either version 2 of >> +# the License, or (at your option) any later version. >> +# >> +# This program is distributed in the hope that it would be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program; if not, write the Free Software Foundation, >> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA >> +# >> +# Author: Alexey Kodanev<[email protected]> >> +# >> +# Include it to build kernel modules. >> +# MODULE_NAMES, REQ_VERSION_MAJOR and REQ_VERSION_PATCH must be defined >> +# beforehand. >> +# >> + >> +ifneq ($(KERNELRELEASE),) >> + >> +obj-m := $(addsuffix .o, $(MODULE_NAMES)) >> + >> +else >> + >> +# prerequisites >> +$(if $(ENV_PRE_LOADED),,\ >> + $(error You must load env_pre.mk before including this file)) >> + >> +$(if $(MODULE_NAMES),,\ >> + $(error You must define MODULE_NAMES)) >> + >> +$(if $(REQ_VERSION_MAJOR),,\ >> + $(error You must define REQ_VERSION_MAJOR)) >> + >> +$(if $(REQ_VERSION_PATCH),,\ >> + $(error You must define REQ_VERSION_MINOR)) >> + >> +export ENV_PRE_LOADED >> +export top_srcdir := $(abs_srcdir)/$(top_srcdir) > I fail to see what are these two exports are for. > > For what reason do we need to redefine top_srcdir? > I redefine top_srcdir to make it absolute because when "make" cd to kernel build directory and once again include LTP Makefile, the first include of env_pre.mk leads to non-existed file and kernel build stops with error. If top_srcdir absolute, no include errors in the kernel build.
Actually we don't need this include of env_pre.mk in the kernel build system because it does nothing with the module build and usually it accomplished with the KERNELRELEASE variable or separate kbuild file. But to preserve the LTP Makefile API and also have a chance to build user-space tests, we include it and tell kernel build system that this one have already been loaded (exporting ENV_PRE_LOAD). ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
