Hi! > Merge msync03.c, msync04.c, msync05.c into one msync03 > test, which contains EINVAL and ENOMEM error value tests. > > And add new EBUSY error value test.
Pushed with minor changes: --- a/testcases/kernel/syscalls/msync/msync03.c +++ b/testcases/kernel/syscalls/msync/msync03.c @@ -1,4 +1,5 @@ /* + * Copyright (c) International Business Machines Corp., 2001 * Copyright (c) 2014 Fujitsu Ltd. * Author: Xiaoguang Wang <[email protected]> * @@ -144,7 +145,7 @@ static void setup(void) #if !defined(UCLINUX) /* memory pointed to by addr4 was not mapped */ - addr4 = get_high_address(); + addr4 = get_high_address(); #endif } @@ -172,14 +173,11 @@ static void cleanup(void) { TEST_CLEANUP; - if (munmap(addr1, page_sz) < 0) + if (addr1 && munmap(addr1, page_sz) < 0) tst_resm(TWARN | TERRNO, "munmap() failed"); if (fd > 0 && close(fd) < 0) tst_resm(TWARN | TERRNO, "close() failed"); - if (unlink(TEMPFILE) < 0) - tst_resm(TWARN | TERRNO, "unlink(%s) failed", TEMPFILE); - tst_rmdir(); } Please do not remove copyright headers unless the test was rewritten from scratch. And you don't have to unlink files in tmpdir, tst_rmdir() does that for you, you only have to close the fds. Thanks. -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
