Both testcases utilise an unset variable - svcaddr.
It's incorrect.

Also added some simple checks of the transport creation.

Signed-off-by: Stanislav Kholmanskikh <[email protected]>
---
 .../tirpc_expertlevel_rpcb_set/tirpc_rpcb_set.c    |   13 ++++++++++---
 .../tirpc_rpcb_unset.c                             |   10 ++++++++--
 2 files changed, 18 insertions(+), 5 deletions(-)

diff --git 
a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_expertlevel_rpcb_set/tirpc_rpcb_set.c
 
b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_expertlevel_rpcb_set/tirpc_rpcb_set.c
index eb42618..f68b045 100644
--- 
a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_expertlevel_rpcb_set/tirpc_rpcb_set.c
+++ 
b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_expertlevel_rpcb_set/tirpc_rpcb_set.c
@@ -47,8 +47,6 @@ int main(int argn, char *argc[])
        int progNum = atoi(argc[2]);
        SVCXPRT *transp = NULL;
        struct netconfig *nconf = NULL;
-       struct netbuf svcaddr;
-
 
        nconf = getnetconfigent("udp");
        if (nconf == (struct netconfig *)NULL) {
@@ -57,8 +55,17 @@ int main(int argn, char *argc[])
        }
 
        transp = svc_tli_create(RPC_ANYFD, nconf, (struct t_bind *)NULL, 0, 0);
+       if (transp == NULL) {
+               printf("svc_tli_create() failed\n");
+               exit(1);
+       }
 
-       test_status = !rpcb_set(progNum, VERSNUM, nconf, &svcaddr);
+       test_status = !rpcb_set(progNum, VERSNUM, nconf, &(transp->xp_ltaddr));
+
+       if (!rpcb_unset(progNum, VERSNUM, nconf)) {
+               printf("rpcb_unset() failed\n");
+               exit(1);
+       }
 
        printf("%d\n", test_status);
 
diff --git 
a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_expertlevel_rpcb_unset/tirpc_rpcb_unset.c
 
b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_expertlevel_rpcb_unset/tirpc_rpcb_unset.c
index adb951f..9e3d67f 100644
--- 
a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_expertlevel_rpcb_unset/tirpc_rpcb_unset.c
+++ 
b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_expertlevel_rpcb_unset/tirpc_rpcb_unset.c
@@ -47,7 +47,6 @@ int main(int argn, char *argc[])
        int progNum = atoi(argc[2]);
        SVCXPRT *transp = NULL;
        struct netconfig *nconf = NULL;
-       struct netbuf svcaddr;
 
        nconf = getnetconfigent("udp");
        if (nconf == (struct netconfig *)NULL) {
@@ -56,8 +55,15 @@ int main(int argn, char *argc[])
        }
 
        transp = svc_tli_create(RPC_ANYFD, nconf, (struct t_bind *)NULL, 0, 0);
+       if (transp == NULL) {
+               printf("svc_tli_create() failed\n");
+               exit(1);
+       }
 
-       rpcb_set(progNum, VERSNUM, nconf, &svcaddr);
+       if (!rpcb_set(progNum, VERSNUM, nconf, &(transp->xp_ltaddr))) {
+               printf("rpcb_set() failed\n");
+               exit(1);
+       }
 
        test_status = !rpcb_unset(progNum, VERSNUM, nconf);
 
-- 
1.7.1


------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to