[LTP] [PATCH 2/2] pwrite/pwrite02.c: make EBADF error value tests sufficient

[Xiaoguang Wang]

Signed-off-by: Xiaoguang Wang <wangxg.f...@cn.fujitsu.com>
---
 testcases/kernel/syscalls/pwrite/pwrite02.c | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/testcases/kernel/syscalls/pwrite/pwrite02.c 
b/testcases/kernel/syscalls/pwrite/pwrite02.c
index 31f1b79..a934de8 100644
--- a/testcases/kernel/syscalls/pwrite/pwrite02.c
+++ b/testcases/kernel/syscalls/pwrite/pwrite02.c
@@ -26,7 +26,8 @@
  *     returns EINVAL.
  *   3) pwrite() fails if fd is not a valid file descriptor,
  *     returns EBADF.
- *   4) pwrite() fails when attempted to write with buf outside
+ *   4) pwrite() fails if fd is not open for writing, return EBADF.
+ *   5) pwrite() fails when attempted to write with buf outside
  *      accessible address space.
  */
 
@@ -59,14 +60,15 @@ static int exp_enos[] = {
 
 static void test_espipe(void);
 static void test_einval(void);
-static void test_ebadf(void);
+static void test_ebadf1(void);
+static void test_ebadf2(void);
 
 #if !defined(UCLINUX)
 static void test_efault(void);
 #endif
 
 static void (*testfunc[])(void) = {
-       test_espipe, test_einval, test_ebadf,
+       test_espipe, test_einval, test_ebadf1, test_ebadf2,
 #if !defined(UCLINUX)
        test_efault
 #endif
@@ -179,7 +181,7 @@ static void test_einval(void)
        SAFE_CLOSE(cleanup, fd);
 }
 
-static void test_ebadf(void)
+static void test_ebadf1(void)
 {
        int fd = -1;
 
@@ -188,6 +190,19 @@ static void test_ebadf(void)
        print_test_result(errno, EBADF);
 }
 
+static void test_ebadf2(void)
+{
+       int fd;
+
+       fd = SAFE_OPEN(cleanup, TEMPFILE, O_RDONLY | O_CREAT, 0666);
+
+       TEST(pwrite(fd, write_buf, K1, 0));
+
+       print_test_result(errno, EBADF);
+
+       SAFE_CLOSE(cleanup, fd);
+}
+
 #if !defined(UCLINUX)
 static void test_efault(void)
 {
-- 
1.8.2.1


------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list