Hi, This version2 is basically similar to the verson1, containing minor changes and detailed commit information. And I have compared the tests in runtest/pipes and the test results in RHEL7.0beta, RHEL6.5GA, RHEL5.10GA are the same between before and after this patch, thanks.
Regards, Xiaoguang Wang On 04/10/2014 05:34 PM, Xiaoguang Wang wrote: > Delete some useless comments and fix some. > > Use SAFE_* macros. > > Make a re-arrangement on original code: let parent process > work in do_parent(), child process work in do_child(), and > arguments parse and initialization work in setup(). > > Delete several useless or pointless options: > Option C: this option is not supported and has no effect to this test. > > Option B: if this option is specified, the parent process will always > return 0, which won't reflect the correct test results. I think it does > not make much sense and remove it. > > Option d: this option is used to specify a directory, where named pipe > is created, other than the current directory. Since tst_tmpdir() will > create a temporary directory, so I think "-d" option can be removed. > > printf() is not async-signal-safe, so use write(2) in signal handler directly. > > Some cleanup. > > Signed-off-by: Xiaoguang Wang <[email protected]> > --- > testcases/kernel/ipc/pipeio/pipeio.c | 955 > ++++++++++++++++------------------- > 1 file changed, 438 insertions(+), 517 deletions(-) > > ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
