Add ENOENT and ENOTDIR error number testes for readdir(2) Signed-off-by: Zeng Linggang <[email protected]> --- runtest/ltplite | 1 + runtest/stress.part3 | 1 + runtest/syscalls | 1 + testcases/kernel/syscalls/.gitignore | 1 + testcases/kernel/syscalls/readdir/readdir21.c | 137 ++++++++++++++++++++++++++ 5 files changed, 141 insertions(+) create mode 100644 testcases/kernel/syscalls/readdir/readdir21.c
diff --git a/runtest/ltplite b/runtest/ltplite index ebe171e..f09c386 100644 --- a/runtest/ltplite +++ b/runtest/ltplite @@ -610,6 +610,7 @@ read04 read04 readdir01 readdir01 readdir02 readdir02 +readdir21 readdir21 readlink01A symlink01 -T readlink01 readlink01 readlink01 diff --git a/runtest/stress.part3 b/runtest/stress.part3 index b21e44b..01e84b4 100644 --- a/runtest/stress.part3 +++ b/runtest/stress.part3 @@ -520,6 +520,7 @@ read04 read04 readdir01 readdir01 readdir02 readdir02 +readdir21 readdir21 readlink01A symlink01 -T readlink01 readlink01 readlink01 diff --git a/runtest/syscalls b/runtest/syscalls index fb3e59f..735fa58 100644 --- a/runtest/syscalls +++ b/runtest/syscalls @@ -808,6 +808,7 @@ readahead02 readahead02 readdir01 readdir01 readdir02 readdir02 +readdir21 readdir21 readlink01A symlink01 -T readlink01 readlink01 readlink01 diff --git a/testcases/kernel/syscalls/.gitignore b/testcases/kernel/syscalls/.gitignore index d5c7bac..1b017eb 100644 --- a/testcases/kernel/syscalls/.gitignore +++ b/testcases/kernel/syscalls/.gitignore @@ -662,6 +662,7 @@ /readahead/readahead02 /readdir/readdir01 /readdir/readdir02 +/readdir/readdir21 /readlink/creat_slink /readlink/readlink01 /readlink/readlink02 diff --git a/testcases/kernel/syscalls/readdir/readdir21.c b/testcases/kernel/syscalls/readdir/readdir21.c new file mode 100644 index 0000000..361ee3d --- /dev/null +++ b/testcases/kernel/syscalls/readdir/readdir21.c @@ -0,0 +1,137 @@ +/* + * Copyright (c) 2014 Fujitsu Ltd. + * Author: Zeng Linggang <[email protected]> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of version 2 of the GNU General Public License as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it would be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + */ +/* + * Test Description: + * Verify that, + * 1. Creat a directory and open it, then delete the directory, ENOENT would + * return. + * 2. File descriptor does not refer to a directory, ENOTDIR would return. + * + * PS: + * This file is for readdir(2) and the other files(readdir01.c and + * readdir02.c) are for readdir(3). + */ + +#define _GNU_SOURCE + +#include <stdio.h> +#include <sys/types.h> +#include <sys/stat.h> +#include <fcntl.h> +#include <errno.h> +#include <unistd.h> +#include "test.h" +#include "usctest.h" +#include "safe_macros.h" +#include "linux_syscall_numbers.h" +#include "lapi/readdir.h" + +char *TCID = "readdir21"; + +#define TEST_DIR "test_dir" +#define TEST_FILE "test_file" +#define DIR_MODE (S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP| \ + S_IXGRP|S_IROTH|S_IXOTH) + +static unsigned int del_dir_fd, file_fd; +static struct old_linux_dirent dirp; +static void setup(void); +static void cleanup(void); + +static struct test_case_t { + unsigned int *fd; + struct old_linux_dirent *dirp; + unsigned int count; + int exp_errno; +} test_cases[] = { + {&del_dir_fd, &dirp, sizeof(struct old_linux_dirent), ENOENT}, + {&file_fd, &dirp, sizeof(struct old_linux_dirent), ENOTDIR}, +}; + +int TST_TOTAL = ARRAY_SIZE(test_cases); +static int exp_enos[] = { ENOENT, ENOTDIR, 0 }; +static void readdir_verify(const struct test_case_t *); + +int main(int argc, char **argv) +{ + int i, lc; + char *msg; + + msg = parse_opts(argc, argv, NULL, NULL); + if (msg != NULL) + tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg); + + setup(); + + for (lc = 0; TEST_LOOPING(lc); lc++) { + tst_count = 0; + for (i = 0; i < TST_TOTAL; i++) + readdir_verify(&test_cases[i]); + } + + cleanup(); + tst_exit(); +} + +static void setup(void) +{ + tst_sig(NOFORK, DEF_HANDLER, cleanup); + + TEST_EXP_ENOS(exp_enos); + + TEST_PAUSE; + + tst_tmpdir(); + + SAFE_MKDIR(cleanup, TEST_DIR, DIR_MODE); + del_dir_fd = SAFE_OPEN(cleanup, TEST_DIR, O_RDONLY | O_DIRECTORY); + if (rmdir(TEST_DIR) == -1) + tst_brkm(TBROK | TERRNO, cleanup, "rmdir failed"); + + file_fd = SAFE_OPEN(cleanup, TEST_FILE, O_RDWR | O_CREAT, 0777); +} + +static void readdir_verify(const struct test_case_t *test) +{ + TEST(ltp_syscall(__NR_readdir, *test->fd, test->dirp, test->count)); + + if (TEST_RETURN != -1) { + tst_resm(TFAIL, "readdir() succeeded unexpectedly"); + return; + } + + if (TEST_ERRNO == test->exp_errno) { + tst_resm(TPASS | TTERRNO, "readdir() failed as expected"); + } else { + tst_resm(TFAIL | TTERRNO, + "readdir() failed unexpectedly; expected: %d - %s", + test->exp_errno, strerror(test->exp_errno)); + } +} + +static void cleanup(void) +{ + TEST_CLEANUP; + + if (del_dir_fd > 0) + close(del_dir_fd); + + if (file_fd > 0) + close(file_fd); + + tst_rmdir(); +} -- 1.8.4.2 ------------------------------------------------------------------------------ Is your legacy SCM system holding you back? Join Perforce May 7 to find out: • 3 signs your SCM is hindering your productivity • Requirements for releasing software faster • Expert tips and advice for migrating your SCM now http://p.sf.net/sfu/perforce _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
