----- Original Message -----
> From: "Xiaoguang Wang" <wangxg.f...@cn.fujitsu.com>
> To: ltp-list@lists.sourceforge.net
> Sent: Wednesday, 14 May, 2014 11:17:35 AM
> Subject: [LTP] [PATCH RFC] change MAKE_TARGETS's dependency to normal 
> prerequisites and order-only prerequisites
> 
> See the below issue:
>   When we made modifications to source files in lib/, for example
>   lib/tst_mkfs.c, then
>   back to testcases/kernel/syscalls/access and execute 'make'. This will not
>   make the
>   access[0-5] to be re-linked with the newly generated libltp.a, we need to
>   touch
>   access[0-5].c or remove access[0-5] files first, then make. This will make
>   no sense.
>   Users may expect just a make command to ensure a new access[0-5] generated
>   with the
>   new libltp.a.
> 
> This is because in 'include/mk/generic_leaf_target.inc', MAKE_TARGETS's
> dependency is
> order-only prerequisites, not normal prerequisites, so we change lib's
> dependency type
> to normal prerequisites, not order-only prerequisites.
> 
> The original MAKE_DEPS is replaced by MAKE_NORMAL_DEPS or
> MAKE_ORDER_ONLY_DEPS.
> 
> Signed-off-by: Xiaoguang Wang <wangxg.f...@cn.fujitsu.com>
> ---
>  include/mk/generic_leaf_target.inc                      | 2 +-
>  include/mk/generic_trunk_target.inc                     | 2 +-
>  include/mk/testcases.mk                                 | 3 ++-
>  testcases/kernel/Makefile                               | 2 +-
>  testcases/kernel/containers/Makefile                    | 2 +-
>  testcases/kernel/containers/Makefile.inc                | 2 +-
>  testcases/kernel/controllers/Makefile                   | 2 +-
>  testcases/kernel/controllers/Makefile.inc               | 2 +-
>  testcases/kernel/controllers/cpuset/Makefile            | 2 +-
>  testcases/kernel/controllers/cpuset/Makefile.inc        | 2 +-
>  testcases/kernel/include/lib.mk                         | 2 +-
>  testcases/kernel/mem/hugetlb/Makefile                   | 2 +-
>  testcases/kernel/mem/hugetlb/Makefile.inc               | 2 +-
>  testcases/kernel/mem/include/libmem.mk                  | 2 +-
>  testcases/kernel/power_management/Makefile              | 2 +-
>  testcases/kernel/syscalls/ipc/Makefile                  | 2 +-
>  testcases/kernel/syscalls/ipc/Makefile.inc              | 2 +-
>  testcases/kernel/syscalls/ipc/msgctl/Makefile           | 2 +-
>  testcases/kernel/syscalls/kill/Makefile                 | 2 +-
>  testcases/kernel/syscalls/mremap/Makefile               | 2 +-
>  testcases/network/rpc/basic_tests/rpc01/Makefile        | 2 +-
>  testcases/network/rpc/rpc-tirpc/tests_pack/Makefile.inc | 2 +-
>  testcases/network/tcp_cmds/Makefile.inc                 | 4 ++--
>  23 files changed, 25 insertions(+), 24 deletions(-)
> 
<snip>
> diff --git a/testcases/kernel/include/lib.mk
> b/testcases/kernel/include/lib.mk
> index c193ca3..c0b9189 100644
> --- a/testcases/kernel/include/lib.mk
> +++ b/testcases/kernel/include/lib.mk
> @@ -32,7 +32,7 @@ $(LIBKERNTEST_DIR):
>  $(LIBKERNTEST): $(LIBKERNTEST_DIR)
>       $(MAKE) -C $^ -f "$(LIBKERNTEST_SRCDIR)/Makefile" all
>  
> -MAKE_DEPS            += $(LIBKERNTEST)
> +MAKE_ORDER_ONLY_DEPS += $(LIBKERNTEST)

Hi,

Why is libkerntest.a order only dependency here?
If we go this way, shouldn't we do it for all libraries?

Regards,
Jan

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to