----- Original Message -----
> From: [email protected]
> To: "Jan Stancek" <[email protected]>
> Cc: [email protected], "Awais Belal" <[email protected]>
> Sent: Monday, 14 July, 2014 3:32:45 PM
> Subject: Re: [LTP] [PATCH] fs-bench: rename test*.sh scripts to 
> fs-bench-test*.sh
> 
> Hi!
> > Install name of these scripts is in conflict with testcases/lib/test.sh.
> > In problem Awais reported, he ended up with test.sh from fs-bench in
> > install directory, instead of shell script library he was expecting:
> >   install -m 00775 "/root/ltp/testcases/lib/test.sh"
> >   "/opt/ltp/testcases/bin/test.sh"
> >   ...
> >   install -m 00775 "/root/ltp/testcases/kernel/fs/fs-bench/test.sh"
> >   "/opt/ltp/testcases/bin/test.sh"
> > 
> > Reported-by: Awais Belal <[email protected]>
> > Signed-off-by: Jan Stancek <[email protected]>
> 
> Looks obvious to me, acked.

Pushed.

Regards,
Jan

> 
> Also we really should add some collision detection to the install phase
> to avoid failures like this one.
> 
> --
> Cyril Hrubis
> [email protected]
> 

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to