Hi! > Some functions used to implement safe macros have parameters > of type off_t or structures containing off_t fields. > > We don't want these to be compiled into libltp, because > some testcases are compiled with different flags such as: > -D_FILE_OFFSET_BITS=64 -DOFF_T=__off64_t > which then creates incompatibility and testcases can fail. > > For example sendfile06_64 on i386: > sendfile06_64 1 TFAIL : sendfile06.c:90: sendfile(2) failed > to return expected value, expected: 17592186044442, got: 26
And I've just found that the same applies to rlim_t used in setrlimit() rlimit structure. (taken from /usr/include/bits/resource.h) /* Type for resource quantity measurement. */ #ifndef __USE_FILE_OFFSET64 typedef __rlim_t rlim_t; #else typedef __rlim64_t rlim_t; #endif #ifdef __USE_LARGEFILE64 typedef __rlim64_t rlim64_t; #endif And the testcase that fails in SAFE_SETRLIMIT() is truncate03_64 after the patch that fixes the EFBIG limit. So unless you are already working on it I will prepare and push a patch that moves rlimit related safe macros to the header as well. -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
