Hi,
function "void tst_mkfs(...)" is used by such flollowing test cases:
testcases/kernel/syscalls/../
creat06
fchown04
fchown04_16
inotify_03
ichown03
ichown03_16
link08
linkat02
mkdir03
mkdirat02
mknod07
mknodat02
mount01
mount06
rename11
reanameat01
rmdir02
umount01
And all of these test cases " tst_sig(NOFORK, DEF_HANDLER, cleanup);" before
calling tst_mkfs.
So when the tst_mkfs calls "if (system("mkfs.btrfs 2>&1 | grep '\\-f '
>/dev/null") == 0) ", the
SIGCHLD will be caught by parent process, and all of the tests will fail.
In my opinion, change the tst_mkfs is the better way.
Thanks and best regards,
--
George Wang 王旭
Kernel Quantity Engineer
Red Hat Software (Beijing) Co.,Ltd
IRC:xuw
Tel:+86-010-62608041
Phone:15901231579
9/F, Tower C, Raycom
----- 原始邮件 -----
发件人: "Cyril Hrubis" <[email protected]>
收件人: [email protected]
抄送: [email protected], [email protected]
发送时间: 星期二, 2014年 11 月 11日 下午 2:49:30
主题: Re: [LTP] [PATCH] tst_mkfs: ignorce SIGCHLD for calling system function
Hi!
> function(3) system will raise the SIGCHILD signal to parent process,
> which should cause the test case failed(especially to btrfs). ignorce
> it before calling the system function and restore it after the calling.
Which test was failing because of this?
Generally testcases should set the correct
tst_sig(FORK, ...) / tst_sig(NOFORK, ...)
even when they use system() or fork() indirectly.
--
Cyril Hrubis
[email protected]
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
